DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: Honnappa.Nagarahalli@arm.com, thomas@monjalon.net,
	Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH 04/17] eal: use previous value atomic fetch operations
Date: Wed,  1 Mar 2023 16:47:35 -0800	[thread overview]
Message-ID: <1677718068-2412-5-git-send-email-roretzla@linux.microsoft.com> (raw)
In-Reply-To: <1677718068-2412-1-git-send-email-roretzla@linux.microsoft.com>

Use __atomic_fetch_{add,and,or,sub,xor} instead of
__atomic_{add,and,or,sub,xor}_fetch when we have no interest in the
result of the operation.

Reduces unnecessary codegen that provided the result of the atomic
operation that was not used.

Change brings closer alignment with atomics available in C11 standard
and will reduce review effort when they are integrated.

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
 lib/eal/common/eal_common_trace.c |  8 ++++----
 lib/eal/common/rte_service.c      |  8 ++++----
 lib/eal/ppc/include/rte_atomic.h  | 16 ++++++++--------
 3 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c
index 75162b7..cb980af 100644
--- a/lib/eal/common/eal_common_trace.c
+++ b/lib/eal/common/eal_common_trace.c
@@ -103,10 +103,10 @@ struct trace_point_head *
 trace_mode_set(rte_trace_point_t *t, enum rte_trace_mode mode)
 {
 	if (mode == RTE_TRACE_MODE_OVERWRITE)
-		__atomic_and_fetch(t, ~__RTE_TRACE_FIELD_ENABLE_DISCARD,
+		__atomic_fetch_and(t, ~__RTE_TRACE_FIELD_ENABLE_DISCARD,
 			__ATOMIC_RELEASE);
 	else
-		__atomic_or_fetch(t, __RTE_TRACE_FIELD_ENABLE_DISCARD,
+		__atomic_fetch_or(t, __RTE_TRACE_FIELD_ENABLE_DISCARD,
 			__ATOMIC_RELEASE);
 }
 
@@ -155,7 +155,7 @@ rte_trace_mode rte_trace_mode_get(void)
 
 	prev = __atomic_fetch_or(t, __RTE_TRACE_FIELD_ENABLE_MASK, __ATOMIC_RELEASE);
 	if ((prev & __RTE_TRACE_FIELD_ENABLE_MASK) == 0)
-		__atomic_add_fetch(&trace.status, 1, __ATOMIC_RELEASE);
+		__atomic_fetch_add(&trace.status, 1, __ATOMIC_RELEASE);
 	return 0;
 }
 
@@ -169,7 +169,7 @@ rte_trace_mode rte_trace_mode_get(void)
 
 	prev = __atomic_fetch_and(t, ~__RTE_TRACE_FIELD_ENABLE_MASK, __ATOMIC_RELEASE);
 	if ((prev & __RTE_TRACE_FIELD_ENABLE_MASK) != 0)
-		__atomic_sub_fetch(&trace.status, 1, __ATOMIC_RELEASE);
+		__atomic_fetch_sub(&trace.status, 1, __ATOMIC_RELEASE);
 	return 0;
 }
 
diff --git a/lib/eal/common/rte_service.c b/lib/eal/common/rte_service.c
index 42ca1d0..7ab48f2 100644
--- a/lib/eal/common/rte_service.c
+++ b/lib/eal/common/rte_service.c
@@ -464,11 +464,11 @@ struct core_state {
 	/* Increment num_mapped_cores to reflect that this core is
 	 * now mapped capable of running the service.
 	 */
-	__atomic_add_fetch(&s->num_mapped_cores, 1, __ATOMIC_RELAXED);
+	__atomic_fetch_add(&s->num_mapped_cores, 1, __ATOMIC_RELAXED);
 
 	int ret = service_run(id, cs, UINT64_MAX, s, serialize_mt_unsafe);
 
-	__atomic_sub_fetch(&s->num_mapped_cores, 1, __ATOMIC_RELAXED);
+	__atomic_fetch_sub(&s->num_mapped_cores, 1, __ATOMIC_RELAXED);
 
 	return ret;
 }
@@ -638,12 +638,12 @@ struct core_state {
 
 		if (*set && !lcore_mapped) {
 			lcore_states[lcore].service_mask |= sid_mask;
-			__atomic_add_fetch(&rte_services[sid].num_mapped_cores,
+			__atomic_fetch_add(&rte_services[sid].num_mapped_cores,
 				1, __ATOMIC_RELAXED);
 		}
 		if (!*set && lcore_mapped) {
 			lcore_states[lcore].service_mask &= ~(sid_mask);
-			__atomic_sub_fetch(&rte_services[sid].num_mapped_cores,
+			__atomic_fetch_sub(&rte_services[sid].num_mapped_cores,
 				1, __ATOMIC_RELAXED);
 		}
 	}
diff --git a/lib/eal/ppc/include/rte_atomic.h b/lib/eal/ppc/include/rte_atomic.h
index 663b4d3..2ab735b 100644
--- a/lib/eal/ppc/include/rte_atomic.h
+++ b/lib/eal/ppc/include/rte_atomic.h
@@ -60,13 +60,13 @@ static inline int rte_atomic16_test_and_set(rte_atomic16_t *v)
 static inline void
 rte_atomic16_inc(rte_atomic16_t *v)
 {
-	__atomic_add_fetch(&v->cnt, 1, __ATOMIC_ACQUIRE);
+	__atomic_fetch_add(&v->cnt, 1, __ATOMIC_ACQUIRE);
 }
 
 static inline void
 rte_atomic16_dec(rte_atomic16_t *v)
 {
-	__atomic_sub_fetch(&v->cnt, 1, __ATOMIC_ACQUIRE);
+	__atomic_fetch_sub(&v->cnt, 1, __ATOMIC_ACQUIRE);
 }
 
 static inline int rte_atomic16_inc_and_test(rte_atomic16_t *v)
@@ -102,13 +102,13 @@ static inline int rte_atomic32_test_and_set(rte_atomic32_t *v)
 static inline void
 rte_atomic32_inc(rte_atomic32_t *v)
 {
-	__atomic_add_fetch(&v->cnt, 1, __ATOMIC_ACQUIRE);
+	__atomic_fetch_add(&v->cnt, 1, __ATOMIC_ACQUIRE);
 }
 
 static inline void
 rte_atomic32_dec(rte_atomic32_t *v)
 {
-	__atomic_sub_fetch(&v->cnt, 1, __ATOMIC_ACQUIRE);
+	__atomic_fetch_sub(&v->cnt, 1, __ATOMIC_ACQUIRE);
 }
 
 static inline int rte_atomic32_inc_and_test(rte_atomic32_t *v)
@@ -157,25 +157,25 @@ static inline int rte_atomic32_dec_and_test(rte_atomic32_t *v)
 static inline void
 rte_atomic64_add(rte_atomic64_t *v, int64_t inc)
 {
-	__atomic_add_fetch(&v->cnt, inc, __ATOMIC_ACQUIRE);
+	__atomic_fetch_add(&v->cnt, inc, __ATOMIC_ACQUIRE);
 }
 
 static inline void
 rte_atomic64_sub(rte_atomic64_t *v, int64_t dec)
 {
-	__atomic_sub_fetch(&v->cnt, dec, __ATOMIC_ACQUIRE);
+	__atomic_fetch_sub(&v->cnt, dec, __ATOMIC_ACQUIRE);
 }
 
 static inline void
 rte_atomic64_inc(rte_atomic64_t *v)
 {
-	__atomic_add_fetch(&v->cnt, 1, __ATOMIC_ACQUIRE);
+	__atomic_fetch_add(&v->cnt, 1, __ATOMIC_ACQUIRE);
 }
 
 static inline void
 rte_atomic64_dec(rte_atomic64_t *v)
 {
-	__atomic_sub_fetch(&v->cnt, 1, __ATOMIC_ACQUIRE);
+	__atomic_fetch_sub(&v->cnt, 1, __ATOMIC_ACQUIRE);
 }
 
 static inline int64_t
-- 
1.8.3.1


  parent reply	other threads:[~2023-03-02  0:48 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02  0:47 [PATCH 00/17] use __atomic operations returning previous value Tyler Retzlaff
2023-03-02  0:47 ` [PATCH 01/17] vhost: use previous value atomic fetch operations Tyler Retzlaff
2023-03-02 14:47   ` Maxime Coquelin
2023-03-02  0:47 ` [PATCH 02/17] telemetry: " Tyler Retzlaff
2023-03-02  9:34   ` Bruce Richardson
2023-03-02  0:47 ` [PATCH 03/17] stack: " Tyler Retzlaff
2023-03-02  0:47 ` Tyler Retzlaff [this message]
2023-03-02  0:47 ` [PATCH 05/17] distributor: " Tyler Retzlaff
2023-03-02  0:47 ` [PATCH 06/17] bbdev: " Tyler Retzlaff
2023-03-02  0:47 ` [PATCH 07/17] examples/vhost: " Tyler Retzlaff
2023-03-02 14:47   ` Maxime Coquelin
2023-03-02  0:47 ` [PATCH 08/17] net/virtio: " Tyler Retzlaff
2023-03-02 14:48   ` Maxime Coquelin
2023-03-02  0:47 ` [PATCH 09/17] net/octeontx: " Tyler Retzlaff
2023-03-02  0:47 ` [PATCH 10/17] net/mlx5: " Tyler Retzlaff
2023-03-02  0:47 ` [PATCH 11/17] net/iavf: " Tyler Retzlaff
2023-03-02  9:28   ` Ruifeng Wang
2023-03-02 15:50     ` Tyler Retzlaff
2023-03-02  0:47 ` [PATCH 12/17] net/cxgbe: " Tyler Retzlaff
2023-03-02  0:47 ` [PATCH 13/17] drivers/event: " Tyler Retzlaff
2023-03-02  0:47 ` [PATCH 14/17] dma/skeleton: " Tyler Retzlaff
2023-03-02  0:47 ` [PATCH 15/17] drivers/common: " Tyler Retzlaff
2023-03-02  0:47 ` [PATCH 16/17] app/test: " Tyler Retzlaff
2023-03-02  0:47 ` [PATCH 17/17] test-eventdev: " Tyler Retzlaff
2023-03-02 14:40 ` [PATCH 00/17] use __atomic operations returning previous value Morten Brørup
2023-03-02 16:18 ` [PATCH v2 " Tyler Retzlaff
2023-03-02 16:18   ` [PATCH v2 01/17] vhost: use previous value atomic fetch operations Tyler Retzlaff
2023-03-02 16:18   ` [PATCH v2 02/17] telemetry: " Tyler Retzlaff
2023-03-02 16:18   ` [PATCH v2 03/17] stack: " Tyler Retzlaff
2023-03-02 16:18   ` [PATCH v2 04/17] eal: " Tyler Retzlaff
2023-03-02 16:18   ` [PATCH v2 05/17] distributor: " Tyler Retzlaff
2023-03-02 16:18   ` [PATCH v2 06/17] bbdev: " Tyler Retzlaff
2023-03-02 16:18   ` [PATCH v2 07/17] examples/vhost: " Tyler Retzlaff
2023-03-02 16:18   ` [PATCH v2 08/17] net/virtio: " Tyler Retzlaff
2023-03-02 16:18   ` [PATCH v2 09/17] net/octeontx: " Tyler Retzlaff
2023-03-02 16:18   ` [PATCH v2 10/17] net/mlx5: " Tyler Retzlaff
2023-03-02 16:18   ` [PATCH v2 11/17] net/iavf: " Tyler Retzlaff
2023-03-02 16:18   ` [PATCH v2 12/17] net/cxgbe: " Tyler Retzlaff
2023-03-02 16:18   ` [PATCH v2 13/17] drivers/event: " Tyler Retzlaff
2023-03-13  7:02     ` [EXT] " Pavan Nikhilesh Bhagavatula
2023-03-02 16:18   ` [PATCH v2 14/17] dma/skeleton: " Tyler Retzlaff
2023-03-02 16:18   ` [PATCH v2 15/17] drivers/common: " Tyler Retzlaff
2023-03-02 16:18   ` [PATCH v2 16/17] app/test: " Tyler Retzlaff
2023-03-02 16:18   ` [PATCH v2 17/17] test-eventdev: " Tyler Retzlaff
2023-03-03  1:54   ` [PATCH v2 00/17] use __atomic operations returning previous value Ruifeng Wang
2023-03-03  2:33   ` fengchengwen
2023-04-25  9:10   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1677718068-2412-5-git-send-email-roretzla@linux.microsoft.com \
    --to=roretzla@linux.microsoft.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).