From: Thomas Monjalon <thomas@monjalon.net>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] devtools: list stable commits do not have fixline
Date: Fri, 28 Apr 2017 10:15:46 +0200 [thread overview]
Message-ID: <1679460.mJD8jeqIBn@xps> (raw)
In-Reply-To: <1493364114-7771-1-git-send-email-yuanhan.liu@linux.intel.com>
28/04/2017 09:21, Yuanhan Liu:
> Some commits for stable releases (with Cc stable tag) may not have the
> fixline. For example:
> http://dpdk.org/dev/patchwork/patch/23955/
>
> It disables a feature we have implemented in last release. The feature
> is done right. It's the QEMU implementaton being buggy, that we have to
> disable it to workaround those buggy QEMU releases (v2.7 - v2.9). Without
> such workaround, QEMU won't start when queue number >= 2.
>
> That said, we also have to backport it to stable releases, though there
> is no fixline (there was no DPDK bug to fix after all).
How do we know where should it be backported?
It is fixing a bug with a correct implementation because of
a buggy dependency. But it is still a bug.
So I think we should put a Fixes: line.
>
> There should be similar cases like this. Thus, this patch makes
> git-log-fixes.sh script also list those stable commits do not have
> fixline.
I am against putting Cc: stable without Fixes: line.
However, this patch is harmless.
next prev parent reply other threads:[~2017-04-28 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 7:21 Yuanhan Liu
2017-04-28 8:15 ` Thomas Monjalon [this message]
2017-04-28 8:27 ` Yuanhan Liu
2017-04-28 9:00 ` Thomas Monjalon
2017-04-28 9:01 ` Yuanhan Liu
2017-04-28 10:07 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1679460.mJD8jeqIBn@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).