From: Luca Boccassi <bluca@debian.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Bruce Richardson <bruce.richardson@intel.com>,
Kevin Laatz <kevin.laatz@intel.com>,
Aaron Conole <aconole@redhat.com>,
Neil Horman <nhorman@tuxdriver.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Anoob Joseph <anoobj@marvell.com>, dpdk stable <stable@dpdk.org>,
Yipeng Wang <yipeng1.wang@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Harry van Haaren <harry.van.haaren@intel.com>,
Keith Wiles <keith.wiles@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/4] hash: fix meson headers packaging
Date: Thu, 30 Jan 2020 10:56:36 +0000 [thread overview]
Message-ID: <167b2eafc1cff4aef40eea97d24819c4f0254ab3.camel@debian.org> (raw)
In-Reply-To: <CAJFAV8zDEjRTTm+niD8H290Qi6RmHRyUxuktx=NAs27+uh4Bfw@mail.gmail.com>
On Thu, 2020-01-30 at 11:54 +0100, David Marchand wrote:
> On Thu, Jan 30, 2020 at 11:12 AM Luca Boccassi <
> bluca@debian.org
> > wrote:
> > On Wed, 2020-01-29 at 18:26 +0100, David Marchand wrote:
> > > Those headers are internal and should not be distributed.
> > >
> > > Fixes: 5b9656b157d3 ("lib: build with meson")
> > > Cc:
> > > stable@dpdk.org
> > >
> > >
> > >
> > > Signed-off-by: David Marchand <
> > > david.marchand@redhat.com
> > >
> > >
> > > ---
> > > lib/librte_hash/meson.build | 5 +----
> > > 1 file changed, 1 insertion(+), 4 deletions(-)
> > >
> > > diff --git a/lib/librte_hash/meson.build
> > > b/lib/librte_hash/meson.build
> > > index 5d02b3084..bce11ad9e 100644
> > > --- a/lib/librte_hash/meson.build
> > > +++ b/lib/librte_hash/meson.build
> > > @@ -1,10 +1,7 @@
> > > # SPDX-License-Identifier: BSD-3-Clause
> > > # Copyright(c) 2017 Intel Corporation
> > >
> > > -headers = files('rte_cmp_arm64.h',
> > > - 'rte_cmp_x86.h',
> > > - 'rte_crc_arm64.h',
> > > - 'rte_cuckoo_hash.h',
> > > +headers = files('rte_crc_arm64.h',
> > > 'rte_fbk_hash.h',
> > > 'rte_hash_crc.h',
> > > 'rte_hash.h',
> >
> > Difficult question: how confident we are nobody is using those? :-)
>
> Those headers are for internal structures.
> When installing with make, those headers were skipped.
>
> Grepping on the dpdk projects that I monitor (based on Stephen list):
>
> $ for header in rte_cmp_arm64.h rte_cmp_x86.h rte_cuckoo_hash.h; do
> echo "======= $header"; git grep-all -l $header; echo; done
> ======= rte_cmp_arm64.h
> F-Stack origin/HEAD:dpdk/lib/librte_hash/meson.build
> F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h
> Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.h
> yastack origin/HEAD:dpdk/lib/librte_hash/meson.build
> yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h
>
> ======= rte_cmp_x86.h
> F-Stack origin/HEAD:dpdk/lib/librte_hash/meson.build
> F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h
> Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.h
> yastack origin/HEAD:dpdk/lib/librte_hash/meson.build
> yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h
>
> ======= rte_cuckoo_hash.h
> F-Stack origin/HEAD:dpdk/lib/librte_hash/meson.build
> F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.c
> F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h
> Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.c
> Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.h
> yastack origin/HEAD:dpdk/lib/librte_hash/meson.build
> yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.c
> yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h
Great, thanks for checking!
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2020-01-30 10:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191220152058.10739-1-david.marchand@redhat.com>
[not found] ` <20200129172621.28565-1-david.marchand@redhat.com>
2020-01-29 17:26 ` [dpdk-stable] " David Marchand
2020-01-30 10:12 ` Luca Boccassi
2020-01-30 10:54 ` David Marchand
2020-01-30 10:56 ` Luca Boccassi [this message]
[not found] ` <20200130160009.6549-1-david.marchand@redhat.com>
2020-01-30 16:00 ` [dpdk-stable] [PATCH v3 " David Marchand
2020-01-30 18:01 ` Wang, Yipeng1
2020-01-30 18:40 ` Honnappa Nagarahalli
2020-02-05 19:51 ` Wang, Yipeng1
[not found] ` <20200202210835.29791-1-david.marchand@redhat.com>
2020-02-02 21:08 ` [dpdk-stable] [PATCH v4 1/3] " David Marchand
2020-02-05 19:53 ` Wang, Yipeng1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167b2eafc1cff4aef40eea97d24819c4f0254ab3.camel@debian.org \
--to=bluca@debian.org \
--cc=aconole@redhat.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=keith.wiles@intel.com \
--cc=kevin.laatz@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=sameh.gobriel@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).