From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: gowrishankar.m@linux.vnet.ibm.com,
jerin.jacob@caviumnetworks.com, jianbo.liu@linaro.org,
sergio.gonzalez.monroy@intel.com, bruce.richardson@intel.com,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 4/4] eal/x86: implement arch-specific TSC freq query
Date: Fri, 13 Oct 2017 09:30:43 +0200 [thread overview]
Message-ID: <1683017.mmorKbpdtt@xps> (raw)
In-Reply-To: <20171012204724.120d7b25@xeon-e3>
13/10/2017 05:47, Stephen Hemminger:
> On Fri, 13 Oct 2017 02:02:47 +0200
> Thomas Monjalon <thomas@monjalon.net> wrote:
>
> > +static uint32_t
> > +check_model_wsm_nhm(uint8_t model)
> > +{
> > + switch (model) {
> > + /* Westmere */
> > + case 0x25:
> > + case 0x2C:
> > + case 0x2F:
> > + /* Nehalem */
> > + case 0x1E:
> > + case 0x1F:
> > + case 0x1A:
> > + case 0x2E:
> > + return 1;
> > + }
> > +
> > + return 0;
> > +}
>
> How about a table rather than switch?
> Also bool rather than int?
It is a matter of taste :)
I plan to push it as is. It can be changed later if desired.
next prev parent reply other threads:[~2017-10-13 7:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 8:25 [dpdk-dev] [PATCH v2 0/5] improve tsc frequency calibration Gowrishankar
2017-09-22 8:25 ` [dpdk-dev] [PATCH v2 1/5] eal/x86: define architecture specific rdtsc hz Gowrishankar
2017-09-22 8:25 ` [dpdk-dev] [PATCH v2 2/5] eal/ppc64: " Gowrishankar
2017-10-12 22:20 ` Thomas Monjalon
2017-09-22 8:25 ` [dpdk-dev] [PATCH v2 3/5] eal/armv7: " Gowrishankar
2017-09-22 8:25 ` [dpdk-dev] [PATCH v2 4/5] eal/armv8: " Gowrishankar
2017-09-22 8:25 ` [dpdk-dev] [PATCH v2 5/5] eal/timer: honor architecture specific rdtsc hz function Gowrishankar
2017-10-11 17:36 ` Thomas Monjalon
2017-10-11 18:57 ` Jerin Jacob
2017-10-11 19:25 ` Thomas Monjalon
2017-10-12 8:48 ` Bruce Richardson
2017-10-12 10:12 ` Thomas Monjalon
2017-10-12 10:25 ` Bruce Richardson
2017-10-12 10:16 ` Jerin Jacob
2017-10-13 0:02 ` [dpdk-dev] [PATCH 0/4] improve tsc frequency calibration Thomas Monjalon
2017-10-13 0:02 ` [dpdk-dev] [PATCH 1/4] timer: honor arch-specific TSC frequency query Thomas Monjalon
2017-10-13 0:02 ` [dpdk-dev] [PATCH 2/4] eal/armv8: implement arch-specific TSC freq query Thomas Monjalon
2017-10-13 0:02 ` [dpdk-dev] [PATCH 3/4] eal/ppc64: " Thomas Monjalon
2017-10-13 0:02 ` [dpdk-dev] [PATCH 4/4] eal/x86: " Thomas Monjalon
2017-10-13 3:47 ` Stephen Hemminger
2017-10-13 7:30 ` Thomas Monjalon [this message]
2017-10-13 15:13 ` Stephen Hemminger
2017-10-13 15:17 ` Bruce Richardson
2017-10-13 3:21 ` [dpdk-dev] [PATCH 0/4] improve tsc frequency calibration Jerin Jacob
2017-10-13 11:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1683017.mmorKbpdtt@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gowrishankar.m@linux.vnet.ibm.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianbo.liu@linaro.org \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).