From: Thomas Monjalon <thomas@monjalon.net>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: dev@dpdk.org, bernard.iremonger@intel.com,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 0/3] fix check of port and core
Date: Wed, 12 May 2021 21:16:17 +0200 [thread overview]
Message-ID: <1687158.auX57ZLpMP@thomas> (raw)
In-Reply-To: <8c549935-875f-ff70-3e1f-5d56503059b7@intel.com>
12/05/2021 18:52, Ferruh Yigit:
> On 4/29/2021 1:50 AM, Min Hu (Connor) wrote:
> > Currently, some examples check that the port is on the same NUMA
> > node as the polling thread for best performance. The method is
> > to compare the socket id of port and that of current core. If the
> > result is different, warning info will be given.
> >
> > But it ignores the port which is from numa node 0, that is, no
> > warning info will be given if the port is from numa node 0, and
> > this set of patches will fix it.
> > ---
> > v3:
> > * change "-w" to "-a".
> >
> > v2:
> > * add more commit info.
> >
> > Min Hu (Connor) (3):
> > examples/flow_classify: fix check of port and core
> > examples/l2fwd-cat: fix check of port and core
> > examples/skeleton: fix check of port and core
> >
>
> For series,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Only I am not sure if it is confusing to mention from 'flow_classify' in the
> commit log of 'l2fwd-cat' or 'skeleton' patches.
Yes it is confusing, I'll drop these comments.
The commits are still not explaining the issue is for devices on node 0,
I'll reword a bit.
Applied, thanks.
prev parent reply other threads:[~2021-05-12 19:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 7:40 [dpdk-dev] [PATCH " Min Hu (Connor)
2021-03-27 7:40 ` [dpdk-dev] [PATCH 1/3] examples/flow_classify: " Min Hu (Connor)
2021-04-20 1:08 ` Thomas Monjalon
2021-04-20 2:26 ` Min Hu (Connor)
2021-04-20 9:40 ` Thomas Monjalon
2021-04-27 11:51 ` Iremonger, Bernard
2021-04-27 12:23 ` Min Hu (Connor)
2021-04-27 13:06 ` Iremonger, Bernard
2021-04-28 9:26 ` Iremonger, Bernard
2021-03-27 7:40 ` [dpdk-dev] [PATCH 2/3] examples/l2fwd-cat: " Min Hu (Connor)
2021-03-27 7:40 ` [dpdk-dev] [PATCH 3/3] examples/skeleton: " Min Hu (Connor)
2021-04-10 9:14 ` [dpdk-dev] [PATCH 0/3] " Min Hu (Connor)
2021-04-19 7:44 ` Min Hu (Connor)
2021-04-21 7:00 ` [dpdk-dev] [PATCH v2 " Min Hu (Connor)
2021-04-21 7:00 ` [dpdk-dev] [PATCH v2 1/3] examples/flow_classify: " Min Hu (Connor)
2021-04-28 13:29 ` Iremonger, Bernard
2021-04-29 0:51 ` Min Hu (Connor)
2021-04-21 7:00 ` [dpdk-dev] [PATCH v2 2/3] examples/l2fwd-cat: " Min Hu (Connor)
2021-04-21 7:00 ` [dpdk-dev] [PATCH v2 3/3] examples/skeleton: " Min Hu (Connor)
2021-04-29 0:50 ` [dpdk-dev] [PATCH v3 0/3] " Min Hu (Connor)
2021-04-29 0:50 ` [dpdk-dev] [PATCH v3 1/3] examples/flow_classify: " Min Hu (Connor)
2021-04-29 9:07 ` Iremonger, Bernard
2021-04-29 9:37 ` Min Hu (Connor)
2021-04-29 11:44 ` Thomas Monjalon
2021-04-29 12:15 ` Min Hu (Connor)
2021-04-29 0:50 ` [dpdk-dev] [PATCH v3 2/3] examples/l2fwd-cat: " Min Hu (Connor)
2021-04-29 0:50 ` [dpdk-dev] [PATCH v3 3/3] examples/skeleton: " Min Hu (Connor)
2021-05-12 16:52 ` [dpdk-dev] [PATCH v3 0/3] " Ferruh Yigit
2021-05-12 19:16 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1687158.auX57ZLpMP@thomas \
--to=thomas@monjalon.net \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).