From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Neil Horman <nhorman@tuxdriver.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@intel.com>, <stable@dpdk.org>,
Jun Yang <jun.yang@nxp.com>
Subject: Re: [dpdk-stable] [PATCH 1/5] pmdinfogen: fix cross compilation for ARM BE
Date: Wed, 13 Dec 2017 17:22:57 +0530 [thread overview]
Message-ID: <16de48c2-0ba7-951a-b8bf-3409cead8663@nxp.com> (raw)
In-Reply-To: <20171211185813.GE18284@hmswarspite.think-freely.org>
Hi Neil/Bruce,
On 12/12/2017 12:28 AM, Neil Horman wrote:
> On Mon, Dec 11, 2017 at 12:40:32PM +0000, Bruce Richardson wrote:
>> On Thu, Nov 02, 2017 at 03:38:51PM +0530, Hemant Agrawal wrote:
>>> cross compiling DPDK for BE mode on ARM results into errors
>>>
>>> "PMDINFO portal/dpaa2_hw_dpio.o.pmd.c No drivers registered"
>>>
>>> Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
>>> Cc: Neil Horman <nhorman@tuxdriver.com>
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Jun Yang <jun.yang@nxp.com>
>>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>>> ---
>>> buildtools/pmdinfogen/pmdinfogen.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>
>> Comment could be a bit more specific about what the problem is and how
>> changing the hard-coded "32" fixes it.
>>
>> Haven't tested the cross compilation part myself, but this causes no
>> errors for 32-bit or 64-bit builds on my system. So, with some more
>> detail on the specifics of the fix in the commit message:
>>
>> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>>
>
> I'm with Bruce. I'd like to know exactly whats going on here. I dont have an
> ARM system handy, so could you please post the errors that you are seeing here?
> Is ADDR_SIZE not defined on BE for ARM or some such? That seems like it should
> be fixed, rather than this change.
>
> Neil
>
The original code hard codes the conversion for sh_size to 32, which is
incorrect.
The sh_size can be "Elf32_Word sh_size" for 32 bit and "Elf64_Xword
sh_size" for 64 bit systems.
This causes the symtab_stop to have reduced size and thus find can fail.
info->symtab_stop = RTE_PTR_ADD(hdr, sechdrs[i].sh_offset +
sechdrs[i].sh_size);
we fixed it by replacing the hardcoded 32 with ADDR_SIZE is better.
I don't have access to Intel BE compiler, so could not check behavior
there. One of difference in my env is that I am doing cross compilation
on intel-x86-64 machine.
I used the following BE compiler
https://releases.linaro.org/components/toolchain/binaries/6.4-2017.11/aarch64_be-linux-gnu/gcc-linaro-6.4.1-2017.11-x86_64_aarch64_be-linux-gnu.tar.xz
>>> diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c
>>> index e73fc76..9119e52 100644
>>> --- a/buildtools/pmdinfogen/pmdinfogen.c
>>> +++ b/buildtools/pmdinfogen/pmdinfogen.c
>>> @@ -181,7 +181,7 @@ static int parse_elf(struct elf_info *info, const char *filename)
>>> sechdrs[i].sh_offset =
>>> TO_NATIVE(endian, ADDR_SIZE, sechdrs[i].sh_offset);
>>> sechdrs[i].sh_size =
>>> - TO_NATIVE(endian, 32, sechdrs[i].sh_size);
>>> + TO_NATIVE(endian, ADDR_SIZE, sechdrs[i].sh_size);
>>> sechdrs[i].sh_link =
>>> TO_NATIVE(endian, 32, sechdrs[i].sh_link);
>>> sechdrs[i].sh_info =
>>> --
>>> 2.7.4
>>>
>>
>
next prev parent reply other threads:[~2017-12-13 11:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 10:08 Hemant Agrawal
2017-11-02 10:08 ` [dpdk-stable] [PATCH 2/5] lpm: fix compilation on " Hemant Agrawal
2017-12-11 12:41 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2017-12-13 12:23 ` [dpdk-stable] " Hemant Agrawal
2017-11-02 10:08 ` [dpdk-stable] [PATCH 4/5] net/i40e: " Hemant Agrawal
2017-11-03 3:03 ` [dpdk-stable] [dpdk-dev] " Xing, Beilei
2017-11-02 10:08 ` [dpdk-stable] [PATCH 5/5] net/ixgbe: " Hemant Agrawal
2017-12-11 12:42 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2017-12-11 12:40 ` [dpdk-stable] [dpdk-dev] [PATCH 1/5] pmdinfogen: fix cross compilation for " Bruce Richardson
2017-12-11 18:58 ` Neil Horman
2017-12-13 11:52 ` Hemant Agrawal [this message]
2017-12-13 12:19 ` [dpdk-stable] " Neil Horman
2017-12-13 12:52 ` [dpdk-stable] [PATCH v2 " Hemant Agrawal
2017-12-13 12:52 ` [dpdk-stable] [PATCH v2 2/5] lpm: fix compilation on " Hemant Agrawal
2017-12-13 13:22 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2017-12-18 7:50 ` [dpdk-stable] " Hemant Agrawal
2017-12-13 12:52 ` [dpdk-stable] [PATCH v2 3/5] bus/dpaa: " Hemant Agrawal
2017-12-13 12:52 ` [dpdk-stable] [PATCH v2 4/5] net/i40e: " Hemant Agrawal
2017-12-13 12:52 ` [dpdk-stable] [PATCH v2 5/5] net/ixgbe: " Hemant Agrawal
2017-12-18 7:56 ` [dpdk-stable] [PATCH v3 1/5] pmdinfogen: fix cross compilation for " Hemant Agrawal
2017-12-18 7:56 ` [dpdk-stable] [PATCH v3 2/5] lpm: fix compilation on " Hemant Agrawal
2017-12-18 7:56 ` [dpdk-stable] [PATCH v3 3/5] bus/dpaa: " Hemant Agrawal
2017-12-18 7:56 ` [dpdk-stable] [PATCH v3 4/5] net/i40e: " Hemant Agrawal
2017-12-18 7:56 ` [dpdk-stable] [PATCH v3 5/5] net/ixgbe: " Hemant Agrawal
2018-01-12 16:27 ` [dpdk-stable] [PATCH v3 1/5] pmdinfogen: fix cross compilation for " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16de48c2-0ba7-951a-b8bf-3409cead8663@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jun.yang@nxp.com \
--cc=nhorman@tuxdriver.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).