From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: allow exec-env specific targets
Date: Tue, 06 Jun 2017 11:11:22 +0200 [thread overview]
Message-ID: <1701124.bcg6lUXj3m@xps> (raw)
In-Reply-To: <20170606090527.GB25773@jerin>
06/06/2017 11:05, Jerin Jacob:
> From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 06/06/2017 09:02, Jerin Jacob:
> > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > Please explain how it can help with a real example.
> > > >
> > > > We are evaluating on running DPDK on a nonstandard execution environment like
> > > > bare metal where I would to keep all my execution environment specific
> > > > change at following location. So that I can easy move around different
> > > > version of DPDK without merge conflict.
> > > >
> > > > $(RTE_SDK)mk/exec-env/my-exec-env
> > > > $(RTE_SDK)lib/librte_eal/my-exec-env
> > > >
> > > > I believe, The existing target like "exec-env-appinstall" in mk/exec-env/linuxapp/rte.app.mk,
> > > > solves the same purpose.
> > >
> > > I do not understand.
> > > If you want to add a new environment, why not just adding it?
> >
> > I do not understand it either. In exiting makefile infrastructure,
> > How do you add an exec environment specific target(s) with out changing
> > the common code?
>
> As disucssed in IRC, I will send the v2 with following changes,
> - Change mk/exec-env/$(RTE_EXEC_ENV)/rte.extra.mk to
> mk/exec-env/$(RTE_EXEC_ENV)/rte.custom.mk
> - Remove empty files and include through -include
It will help defining some new local environments.
However, in the general case, it is better to upstream environment changes
and make everybody able to use it.
next prev parent reply other threads:[~2017-06-06 9:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 6:36 Jerin Jacob
2017-06-06 6:46 ` Thomas Monjalon
2017-06-06 7:02 ` Jerin Jacob
2017-06-06 7:16 ` Thomas Monjalon
2017-06-06 7:50 ` Jerin Jacob
2017-06-06 9:05 ` Jerin Jacob
2017-06-06 9:11 ` Thomas Monjalon [this message]
2017-06-06 12:58 ` [dpdk-dev] [PATCH v2] " Jerin Jacob
2017-07-03 21:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1701124.bcg6lUXj3m@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).