patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Pattan, Reshma" <reshma.pattan@intel.com>
Cc: dev@dpdk.org, "stable@dpdk.org" <stable@dpdk.org>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup
Date: Thu, 17 Jan 2019 21:23:59 +0100	[thread overview]
Message-ID: <17017098.YGx1iN1oWD@xps> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A400A38@irsmsx110.ger.corp.intel.com>

15/01/2019 11:25, Pattan, Reshma:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 15/01/2019 11:09, Pattan, Reshma:
> > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > > 11/01/2019 18:51, Reshma Pattan:
> > > > > Virtual devices added in pdump application using
> > > > > rte_eal_hotplug_add should be removed explicitly while existing
> > > > > the pdump application, otherwise the
> > > >
> > > > existing -> exiting ?
> > > >
> > > > > subsequent run of the pdump application will fail with the reason
> > > > > that virtual devices with the same name already exists in primary.
> > > > >
> > > > > Fixes: 6362f362a2 ("app/pdump: use EAL hotplug instead of ethdev
> > > > > attach")
> > > > > CC: stable@dpdk.org
> > > > > CC: ferruh.yigit@intel.com
> > > >
> > > > Why is it marked as a fix of this commit?
> > > > Is it a miss in the conversion from ethdev attach calls?
> > > > Or a changed behaviour with hotplug functions?
> > >
> > > It is changed behaviour with hotplug functions.
> > 
> > Please, could you explain?
> > 
> 
> Attach calls were replaced with rte_eal_hotplug_remove() in pdump in the commit id given in Fixes line.
> 
> And after this change, the subsequent runs(other than 1st) of pdump application are failing with below error
> 
> 1)Pdump application error:
> 
> EAL: Failed to hotplug add device
> EAL: Error - exiting with code: 1
>   Cause: vdev creation failed:create_mp_ring_vdev:706
> 
> 2)And error on primary application side is below:
> 	testpmd> Ethernet device with name net_pcap_rx_0 already allocated
>                 EAL: Failed to hotplug add device on primary
> 
> So, the dev added in secondary should be removed during its exit by calling rte_eal_hotplug_remove ().
> 
> So,  that is the reason I chose the Fixes: commit as the one where rte_eal_hotplug_add() replaced the attach.
> 
> Earlier with attach calls though not detaching the devices upon application exit, these issues are not seen.

OK
I won't dig to understand why this error was hidden with previous API.
I'll assume there is no need to backport this fix in 17.11.

  reply	other threads:[~2019-01-17 20:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11 17:41 [dpdk-stable] [PATCH v2] " Reshma Pattan
2019-01-11 17:51 ` [dpdk-stable] [PATCH v3] " Reshma Pattan
2019-01-15  0:59   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-01-15 10:09     ` Pattan, Reshma
2019-01-15 10:10       ` Thomas Monjalon
2019-01-15 10:25         ` Pattan, Reshma
2019-01-17 20:23           ` Thomas Monjalon [this message]
2019-01-15 13:45   ` [dpdk-stable] [PATCH v4] " Reshma Pattan
2019-01-15 14:57     ` Ferruh Yigit
2019-01-17 20:28       ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17017098.YGx1iN1oWD@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).