From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Jason Wang <jasowang@redhat.com>,
tiwei.bie@intel.com, zhihong.wang@intel.com,
jfreimann@redhat.com, dev@dpdk.org
Cc: mst@redhat.com, wexu@redhat.com
Subject: Re: [dpdk-dev] [PATCH v6 14/15] vhost: add notification for packed ring
Date: Tue, 3 Jul 2018 08:43:36 +0200 [thread overview]
Message-ID: <1702eff2-3088-4793-5a0c-88b78fc66961@redhat.com> (raw)
In-Reply-To: <07e990f9-6411-6ae7-935c-c51cce80dd7a@redhat.com>
On 07/03/2018 07:57 AM, Jason Wang wrote:
>
>
> On 2018年07月02日 16:16, Maxime Coquelin wrote:
>> +static inline int
>> +vhost_enable_notify_split(struct vhost_virtqueue *vq, int enable)
>> +{
>> + if (enable)
>> + vq->used->flags &= ~VRING_USED_F_NO_NOTIFY;
>> + else
>> + vq->used->flags |= VRING_USED_F_NO_NOTIFY;
>> +
>> + return 0;
>> +}
>> +
>> +static inline int
>> +vhost_enable_notify_packed(struct virtio_net *dev,
>> + struct vhost_virtqueue *vq, int enable)
>> +{
>> + uint16_t flags;
>> +
>> + if (!enable) {
>> + vq->device_event->desc_event_flags = RING_EVENT_FLAGS_DISABLE;
>> + return 0;
>> + }
>> +
>> + flags = RING_EVENT_FLAGS_ENABLE;
>> + if (dev->features & (1ULL << VIRTIO_RING_F_EVENT_IDX)) {
>> + flags = RING_EVENT_FLAGS_DESC;
>> + vq->device_event->desc_event_off_wrap = vq->last_avail_idx |
>> + vq->avail_wrap_counter << 15;
>> + }
>> +
>> + rte_smp_wmb();
>> +
>> + vq->device_event->desc_event_flags = flags;
>> +
>> + rte_smp_wmb();
>> +
>
> We don't do this for split version. Any specific reason for this?
Yeah, maybe this is no necessary.
> Btw, looks like we don't care about the return value so using void instead?
Right, it could be a void.
Thanks!
Maxime
> Thanks
>
>> + return 0;
>> +}
>> +
>
>
next prev parent reply other threads:[~2018-07-03 6:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 8:16 [dpdk-dev] [PATCH v6 00/15] Vhost: add support to packed ring layout Maxime Coquelin
2018-07-02 8:16 ` [dpdk-dev] [PATCH v6 01/15] vhost: add virtio packed virtqueue defines Maxime Coquelin
2018-07-04 5:37 ` Tiwei Bie
2018-07-04 16:03 ` Maxime Coquelin
2018-07-02 8:16 ` [dpdk-dev] [PATCH v6 02/15] vhost: add helpers for packed virtqueues Maxime Coquelin
2018-07-04 5:39 ` Tiwei Bie
2018-07-04 16:03 ` Maxime Coquelin
2018-07-02 8:16 ` [dpdk-dev] [PATCH v6 03/15] vhost: vring address setup for packed queues Maxime Coquelin
2018-07-02 8:16 ` [dpdk-dev] [PATCH v6 04/15] vhost: clear shadow used table index at flush time Maxime Coquelin
2018-07-02 8:16 ` [dpdk-dev] [PATCH v6 05/15] vhost: make indirect desc table copy desc type agnostic Maxime Coquelin
2018-07-02 8:16 ` [dpdk-dev] [PATCH v6 06/15] vhost: clear batch copy index at copy time Maxime Coquelin
2018-07-02 8:16 ` [dpdk-dev] [PATCH v6 07/15] vhost: extract split ring handling from Rx and Tx functions Maxime Coquelin
2018-07-04 6:51 ` Tiwei Bie
2018-07-04 21:04 ` Maxime Coquelin
2018-07-02 8:16 ` [dpdk-dev] [PATCH v6 08/15] vhost: append shadow used ring function names with split Maxime Coquelin
2018-07-02 8:16 ` [dpdk-dev] [PATCH v6 09/15] vhost: add shadow used ring support for packed rings Maxime Coquelin
2018-07-02 8:16 ` [dpdk-dev] [PATCH v6 10/15] vhost: create descriptor mapping function Maxime Coquelin
2018-07-04 5:56 ` Tiwei Bie
2018-07-04 16:18 ` Maxime Coquelin
2018-07-02 8:16 ` [dpdk-dev] [PATCH v6 11/15] vhost: add vector filling support for packed ring Maxime Coquelin
2018-07-04 5:53 ` Tiwei Bie
2018-07-04 16:18 ` Maxime Coquelin
2018-07-02 8:16 ` [dpdk-dev] [PATCH v6 12/15] vhost: add Rx " Maxime Coquelin
2018-07-02 8:16 ` [dpdk-dev] [PATCH v6 13/15] vhost: add Tx " Maxime Coquelin
2018-07-04 5:45 ` Tiwei Bie
2018-07-04 16:09 ` Maxime Coquelin
2018-07-02 8:16 ` [dpdk-dev] [PATCH v6 14/15] vhost: add notification " Maxime Coquelin
2018-07-03 5:57 ` Jason Wang
2018-07-03 6:43 ` Maxime Coquelin [this message]
2018-07-03 6:06 ` Jason Wang
2018-07-04 16:02 ` Maxime Coquelin
2018-07-04 6:25 ` Tiwei Bie
2018-07-04 20:20 ` Maxime Coquelin
2018-07-02 8:16 ` [dpdk-dev] [PATCH v6 15/15] vhost: advertize packed ring layout support Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1702eff2-3088-4793-5a0c-88b78fc66961@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=jasowang@redhat.com \
--cc=jfreimann@redhat.com \
--cc=mst@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=wexu@redhat.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).