From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Harman Kalra <hkalra@marvell.com>,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH v2 0/2] build and install only one library type on Windows
Date: Thu, 14 Mar 2024 23:30:20 -0700 [thread overview]
Message-ID: <1710484222-17310-1-git-send-email-roretzla@linux.microsoft.com> (raw)
In-Reply-To: <1710445477-23848-1-git-send-email-roretzla@linux.microsoft.com>
MSVC is the only compiler that can produce usable shared libraries for
DPDK on Windows because of the use of exported TLS variables.
Disable building of shared libraries with LLVM and MinGW so that
remaining __declspec macros needed for the functional libraries built by
MSVC can be used without triggering errors in LLVM and MinGW builds.
For Windows only install the default_library type to avoid confusion.
Windows builds cannot build both shared and static in a single pass so
install only the functional variant
MSVC does not guarantee any kind of compatibility for static libraries so
they should not be packaged and instead they should be rebuilt along with
the application using the same version of the compiler & linker. Because
of this we have chosen to build only one library type at a time instead of
compiling twice to produce both types in a single pass.
v2:
* add patch to chkings to use static dependencies when building static
cross build for windows target with mingw.
* add missing msvc specific ldflags needed for shared builds.
* define RTE_BUILD_SHARED_LIB for shared msvc builds.
* fix is_shared_enabled conditional to check default_library=shared
when building with msvc.
* simplify linker flags when building for windows, we only need to
provide flags for shared builds when building with msvc.
* stop generating .def file for llvm and mingw builds, since no shared
builds are performed the .def files would be unused.
Tyler Retzlaff (2):
build: build only one library type on Windows
buildtools: when building static library use static deps
app/meson.build | 6 +++
buildtools/chkincs/meson.build | 18 +++++---
config/meson.build | 27 ++++++++++++
drivers/meson.build | 72 +++++++++++++++----------------
drivers/net/octeontx/base/meson.build | 2 +-
examples/meson.build | 6 +++
lib/meson.build | 79 +++++++++++++++--------------------
7 files changed, 121 insertions(+), 89 deletions(-)
--
1.8.3.1
next prev parent reply other threads:[~2024-03-15 6:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 19:44 [PATCH] " Tyler Retzlaff
2024-03-14 19:44 ` [PATCH] build: build " Tyler Retzlaff
2024-03-15 6:30 ` Tyler Retzlaff [this message]
2024-03-15 6:30 ` [PATCH v2 1/2] " Tyler Retzlaff
2024-04-12 13:00 ` Bruce Richardson
2024-04-12 23:04 ` Tyler Retzlaff
2024-04-15 9:42 ` Bruce Richardson
2024-03-15 6:30 ` [PATCH v2 2/2] buildtools: when building static library use static deps Tyler Retzlaff
2024-03-15 8:28 ` Bruce Richardson
2024-04-04 18:47 ` Tyler Retzlaff
2024-04-05 9:11 ` Bruce Richardson
2024-04-12 14:09 ` Bruce Richardson
2024-04-12 22:52 ` Tyler Retzlaff
2024-04-12 22:52 ` [PATCH v3 0/2] build and install only one library type on Windows Tyler Retzlaff
2024-04-12 22:52 ` [PATCH v3 1/2] build: build " Tyler Retzlaff
2024-04-15 9:55 ` Bruce Richardson
2024-04-12 22:52 ` [PATCH v3 2/2] buildtools: when building static library use static deps Tyler Retzlaff
2024-04-15 9:56 ` Bruce Richardson
2024-04-15 16:45 ` [PATCH v4 0/2] build and install only one library type on Windows Tyler Retzlaff
2024-04-15 16:45 ` [PATCH v4 1/2] build: build " Tyler Retzlaff
2024-04-15 16:45 ` [PATCH v4 2/2] buildtools: when building static library use static deps Tyler Retzlaff
2024-04-15 17:12 ` [PATCH v5 0/2] build and install only one library type on Windows Tyler Retzlaff
2024-04-15 17:12 ` [PATCH v5 1/2] build: build " Tyler Retzlaff
2024-04-15 17:24 ` Bruce Richardson
2024-04-15 17:12 ` [PATCH v5 2/2] buildtools: when building static library use static deps Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1710484222-17310-1-git-send-email-roretzla@linux.microsoft.com \
--to=roretzla@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).