From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Jan Viktorin <viktorin@rehivetech.com>
Subject: Re: [dpdk-dev] [PATCH v2] eal: add architecture specific rte_cpuflags.c files
Date: Tue, 02 Feb 2016 11:20:21 +0100 [thread overview]
Message-ID: <1729554.7VcsXzVtRs@xps13> (raw)
In-Reply-To: <1453983623-20709-1-git-send-email-ferruh.yigit@intel.com>
2016-01-28 12:20, Ferruh Yigit:
> Move cpu_feature_table array from arch specific rte_cpuflags.h files to
> new arch specific rte_cpuflags.c files.
>
> Main motivation is to escape from static variable declarations in
> header files. cpu_feature_table has many copies in final binary, even
> exist in some object files that does not use this variable at all.
>
> And this can be a sample to create architecture specific source files
> and move some functions which are not performance sensitive from
> architecture header files to source files.
>
> v2:
> * rebased for DPDK2.3 (16.04)
> * added arm arch
> * renamed cpu_feature_table[] to rte_cpu_feature_table[]
Applied, thanks.
Now that we have some .c files for rte_cpuflags, I think some code
may be changed.
The function rte_cpu_get_features() and the struct feature_entry are
really specific to each arch and used only by rte_cpu_get_flag_enabled().
So they can be moved in .c and be more specific (leaf/subleaf is unused
for some archs).
Then there is no reason to keep rte_cpu_get_flag_enabled() inline.
prev parent reply other threads:[~2016-02-02 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 10:02 [dpdk-dev] [PATCH] " Ferruh Yigit
2016-01-27 17:52 ` Thomas Monjalon
2016-01-28 12:20 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2016-02-02 10:20 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1729554.7VcsXzVtRs@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).