From: Thomas Monjalon <thomas@monjalon.net>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Lijuan Tu <lijuan.tu@intel.com>,
Owen Hilyard <ohilyard@iol.unh.edu>
Subject: Re: [PATCH] devtools: set DTS directory to format check
Date: Thu, 10 Nov 2022 11:26:00 +0100 [thread overview]
Message-ID: <1729999.A0I09U8b9p@thomas> (raw)
In-Reply-To: <464c6b5616664baa90655f6236fde2b2@pantheon.tech>
10/11/2022 10:27, Juraj Linkeš:
> From: Thomas Monjalon <thomas@monjalon.net>
> > usage() {
> > - echo "Run formatting and linting programs for DTS. Usage:"
> > -
> > + echo 'Usage: $(basename $0) [options] [directory]'
>
> Double quotes here, otherwise $0 won't be expanded.
I wonder how I tested it :)
> > +directory=${1:-$(dirname $0)/../dts}
> > +cd $directory || exit 1
>
> I'd like to include the information of where we're doing the fomatting in the console output, e.g.:
> echo "Formatting in $(pwd):"
>
> We're silently chaning the directory, so this would be useful when running with no argument and the script doesn't change anything - as a confirmation that it ran over the files we wanted to.
Good comment, I'll improve in v2.
> Other than that,
> Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Tested-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
No it does not work, so you should not add your Tested-by.
And in general, Reviewed-by is enough.
And really, give your reviewed-by only when it's perfect :)
next prev parent reply other threads:[~2022-11-10 10:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 17:09 Thomas Monjalon
2022-11-09 17:38 ` Owen Hilyard
2022-11-10 9:27 ` Juraj Linkeš
2022-11-10 10:26 ` Thomas Monjalon [this message]
2022-11-10 10:53 ` Juraj Linkeš
2022-11-11 10:06 ` Juraj Linkeš
2022-11-11 10:12 ` Thomas Monjalon
2022-11-23 11:22 ` [PATCH v2] " Thomas Monjalon
2022-11-23 13:41 ` Juraj Linkeš
2022-11-23 15:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1729999.A0I09U8b9p@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=lijuan.tu@intel.com \
--cc=ohilyard@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).