From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH dpdk v2] vfio/ppc64/spapr: Warn if DMA window was created at unexpected offset
Date: Tue, 17 Oct 2017 18:13:14 +0200 [thread overview]
Message-ID: <1734105.V98Xar4r66@xps> (raw)
In-Reply-To: <C6ECDF3AB251BE4894318F4E4512369782211472@IRSMSX109.ger.corp.intel.com>
28/04/2017 13:19, Burakov, Anatoly:
> From: Alexey Kardashevskiy
> > VFIO_IOMMU_SPAPR_TCE_CREATE ioctl() returns the actual bus address for
> > just created DMA window. It happens to start from zero because the default
> > window is removed (leaving no windows) and new window starts from zero.
> > However this is not guaranteed and a new window may start from another
> > address, this adds a check and an error message.
> >
> >
> > Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> > ---
> > Changes:
> > v2:
> > * this just prints warning and fails instead of incorrectly changing IOVA
> > addresses
> > ---
>
> Hi Alexey,
>
> There are some compile failures with this patch. You'll probably want to replace %lx with PRIx64 or similar :)
>
> I would argue that just saying "DMA offsets other than zero are not supported" will be sufficient and will make error message less confusing. Up to you though.
Please, can we progress on this patch?
Is it still a relevant patch?
If yes, someone to make a v3, please?
next prev parent reply other threads:[~2017-10-17 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 8:09 Alexey Kardashevskiy
2017-04-28 11:19 ` Burakov, Anatoly
2017-10-17 16:13 ` Thomas Monjalon [this message]
2017-10-18 5:11 ` Alexey Kardashevskiy
2017-10-18 6:24 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1734105.V98Xar4r66@xps \
--to=thomas@monjalon.net \
--cc=aik@ozlabs.ru \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).