From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Remy Horton <remy.horton@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: Out-by-one in get/set EEPROM
Date: Wed, 16 Sep 2015 15:23:39 +0200 [thread overview]
Message-ID: <1735667.JZ2y0EAyYG@xps13> (raw)
In-Reply-To: <1442408865-7569-1-git-send-email-remy.horton@intel.com>
2015-09-16 14:07, Remy Horton:
> Incorrect operator in ixgbe_get_eeprom & ixgbe_set_eeprom prevents
> last byte of EEPROM being read/written, and hence cannot be dumped
> or updated in entirity using these functions.
This explanation is good but the title is not clear enough. It should
start with "ixgbe: fix". Fix what? I'd say "fix access to last byte of EEPROM".
Then creating a commit starting with "fix" should trigger 2 other things:
- a Fixes: tag
- an update in the release notes (because the bug exists in previous releases)
Thanks
next prev parent reply other threads:[~2015-09-16 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 13:07 Remy Horton
2015-09-16 13:23 ` Thomas Monjalon [this message]
2015-09-17 9:05 ` [dpdk-dev] [PATCH v2] ixgbe: fix access to last byte of EEPROM Remy Horton
2015-09-17 10:13 ` Thomas Monjalon
2015-09-17 13:47 ` [dpdk-dev] [PATCH v3] " Remy Horton
2015-09-21 9:13 ` Ananyev, Konstantin
2015-10-28 16:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1735667.JZ2y0EAyYG@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).