From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/3] app/test: enable test_red to build on non x86 platform
Date: Thu, 27 Aug 2015 11:04:32 +0200 [thread overview]
Message-ID: <1740827.rQGZo3YydZ@xps13> (raw)
In-Reply-To: <20150827040839.GA5223@localhost.localdomain>
2015-08-27 09:38, Jerin Jacob:
> On Tue, Aug 25, 2015 at 02:03:13PM +0200, Thomas Monjalon wrote:
> > 2015-08-18 18:10, Jerin Jacob:
> > > --- a/app/test/test_red.c
> > > +++ b/app/test/test_red.c
> > > +#if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) || defined(RTE_ARCH_X86_X32)
> > > #ifdef __PIC__
> > > asm volatile (
> > > "mov %%ebx, %%edi\n"
> > > @@ -155,6 +156,7 @@ static inline void rdtsc_prof_start(struct rdtsc_prof *p)
> > > #else
> > > asm( "cpuid" : : : "%eax", "%ebx", "%ecx", "%edx" );
> > > #endif
> > > +#endif
> > > p->clk_start = rte_rdtsc();
> >
> > The right fix would be to move that arch-specific code into an EAL abstraction.
>
> I agree. I thought the same. But I am not able to understand why 'cpuid'
> instruction used here without any input/output parameters. What is the
> role of 'cpuid' instruction in this specific function and what to
> abstract in eal ?
It is explained here:
http://dpdk.org/ml/archives/dev/2014-January/001182.html
I think it can be replaced by rte_rdtsc_precise() which was implemented
after the above discussion. It uses rte_mb instead of cpuid.
As explained in the following thread, memory fence can be used instead of cpuid:
http://stackoverflow.com/a/12634857
As showed in the following threads, rdtscp can also be used:
http://stackoverflow.com/a/27697754
http://dpdk.org/ml/archives/dev/2015-April/016770.html
It reminds me that we should deprecate rte_rdtsc() and rte_get_tsc_cycles() in
favor of a more generic name, e.g. rte_get_clock_cycles().
prev parent reply other threads:[~2015-08-27 9:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 12:40 [dpdk-dev] [PATCH 0/3] fix build issues with librte_sched, test_red " Jerin Jacob
2015-08-18 12:40 ` [dpdk-dev] [PATCH 1/3] sched: remove unused inclusion of tmmintrin.h Jerin Jacob
2015-08-18 12:40 ` [dpdk-dev] [PATCH 2/3] app/test: test_sched: fix needless build dependency on CONFIG_RTE_ARCH_X86_64 Jerin Jacob
2015-08-18 12:40 ` [dpdk-dev] [PATCH 3/3] app/test: enable test_red to build on non x86 platform Jerin Jacob
2015-08-25 12:03 ` Thomas Monjalon
2015-08-27 4:08 ` Jerin Jacob
2015-08-27 9:04 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1740827.rQGZo3YydZ@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).