From: Luca Vizzarro <luca.vizzarro@arm.com>
To: Andrew Bailey <abailey@iol.unh.edu>
Cc: dev@dpdk.org, dmarx@iol.unh.edu, ivan.malov@arknetworks.am,
probb@iol.unh.edu, Jeremy Spewock <jspewock@iol.unh.edu>
Subject: Re: [PATCH v4 2/3] dts: add TX offload capabilities to NIC capabilities
Date: Thu, 25 Sep 2025 17:05:28 +0100 [thread overview]
Message-ID: <175881619867.11927.5707525371318324652.luca.vizzarro@arm.com> (raw)
In-Reply-To: <20250924164725.168773-3-abailey@iol.unh.edu>
Hi Andrew,
Looks good! Just a small nit left.
On Wed, Sep 24, 2025 at 12:47:24PM +0000, Andrew Bailey wrote:
> diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py
> index ecbdd66edd..db7e33222a 100644
> --- a/dts/framework/remote_session/testpmd_shell.py
> +++ b/dts/framework/remote_session/testpmd_shell.py
> @@ -1278,7 +1279,99 @@ class TestPmdVerbosePacket(TextParser):
> )
>
>
> -class RxOffloadCapability(Flag):
> +class OffloadCapability(Flag):
> + """Flags generated from RxOffloadCapabilites and TxOffloadCapabilities classes."""
<snip>
> + @classmethod
> + def make_parser(
> + cls, per_port: Literal["port", "queue"], /, find_multiple: bool = False
> + ) -> ParserFn:
> + """Make a parser function.
> +
> + Args:
> + per_port: If :data:`True`, will return capabilities per port. If :data:`False`,
> + will return capabilities per queue.
just a small nit: this doc doesn't match what it is anymore. Similarly
the argument name is not entirely valid either.
> + find_multiple: If :data:`True`, will use :func:`TextParser.find_all` to find all
> + matches for the regex query and return a list of instances based on those matches.
> + If :data:`False`, will return a single instance of the flag based off a single
> + match.
> +
> + Returns:
> + ParserFn: A dictionary for the `dataclasses.field` metadata argument containing a
> + parser function that makes an instance of this flag from text.
> + """
> + granularity = per_port.capitalize()
> + regex = rf"{granularity}[\s\[\]\d]+:(.*)$"
> + if find_multiple:
> + return TextParser.wrap(TextParser.find_all(regex, re.MULTILINE), cls.from_list)
> + return TextParser.wrap(TextParser.find(regex, re.MULTILINE), cls.from_string)
<snip>
next prev parent reply other threads:[~2025-09-25 16:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 11:43 [PATCH v1 0/3] dts: add tx_offload support in dts Andrew Bailey
2025-09-02 11:43 ` [PATCH v1 1/3] dts: fix docstring typo in checksum suite Andrew Bailey
2025-09-02 11:43 ` [PATCH v1 2/3] dts: add reception check to checksum offload suite Andrew Bailey
2025-09-02 11:43 ` [PATCH v1 3/3] dts: all are one Andrew Bailey
2025-09-02 11:48 ` [PATCH v1 0/3] dts: add tx_offload support in dts Andrew Bailey
2025-09-24 16:47 ` [PATCH v4 0/3] dts:add " Andrew Bailey
2025-09-24 16:47 ` [PATCH v4 1/3] dts: allow mbuf_fast_free to be set with testpmd shell Andrew Bailey
2025-09-24 20:51 ` Patrick Robb
2025-09-25 16:01 ` Luca Vizzarro
2025-09-24 16:47 ` [PATCH v4 2/3] dts: add TX offload capabilities to NIC capabilities Andrew Bailey
2025-09-24 20:51 ` Patrick Robb
2025-09-25 16:05 ` Luca Vizzarro [this message]
2025-09-24 16:47 ` [PATCH v4 3/3] dts: update tx_offload test from old dts Andrew Bailey
2025-09-24 20:53 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175881619867.11927.5707525371318324652.luca.vizzarro@arm.com \
--to=luca.vizzarro@arm.com \
--cc=abailey@iol.unh.edu \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=ivan.malov@arknetworks.am \
--cc=jspewock@iol.unh.edu \
--cc=probb@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).