From: Thomas Monjalon <thomas@monjalon.net>
To: chunmei Liu <chunmei.liu@intel.com>
Cc: dev@dpdk.org, olivier.matz@6wind.com,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk
Date: Thu, 14 Dec 2017 08:47:08 +0100 [thread overview]
Message-ID: <1763160.jo7ZIxlbMU@xps> (raw)
In-Reply-To: <1513208695-65016-1-git-send-email-chunmei.liu@intel.com>
14/12/2017 00:44, chunmei Liu:
> From: chunmei <chunmei.liu@intel.com>
>
> ceph async messenger has some run time error with this dpdk library,
> 1) need set rxm->next= null at end of packet since not init it to null
> when allocate a buffer other wise rte_mbuf_sanity_check will report error.
> 2) when check the size, can't calculate mbuf_data_room_size
> because async messenger dpdk will allocate this part later
> not at create mempool.
>
> Signed-off-by: chunmei Liu <chunmei.liu@intel.com>
Hi Chunmei,
Several comments about the formatting:
I've already notified you that you should Cc Olivier for mbuf changes.
You should also Cc Wenzhuo and Konstantin for ixgbe change.
Please add them in your next emails.
The title should show what is fixed, not the use-case.
When sending a new revision of the patch, you should increment
the version number and add a changelog below the ---.
Please use --in-reply-to when sending a new version, in order
to keep track of all versions in the same thread.
Your author name and SoB name should be the same
(your full name with uppercases):
Chunmei Liu <chunmei.liu@intel.com>
For more informations, you should read this:
http://dpdk.org/dev#send
Thank you
next prev parent reply other threads:[~2017-12-14 7:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 23:44 chunmei Liu
2017-12-14 7:47 ` Thomas Monjalon [this message]
2017-12-14 9:24 ` Olivier MATZ
2017-12-14 11:54 ` Ananyev, Konstantin
-- strict thread matches above, loose matches on Subject: below --
2017-12-13 23:40 chunmei Liu
2017-12-13 19:32 chunmei Liu
2017-12-13 21:18 ` Thomas Monjalon
2017-12-13 21:31 ` Stephen Hemminger
2017-12-13 22:34 ` Liu, Chunmei
2017-12-13 22:46 ` Liu, Chunmei
2017-12-13 22:51 ` Stephen Hemminger
2017-12-13 19:28 chunmei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1763160.jo7ZIxlbMU@xps \
--to=thomas@monjalon.net \
--cc=chunmei.liu@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).