From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Chauskin, Igor" <igorch@amazon.com>, Gavin Hu <gavin.hu@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "nd@arm.com" <nd@arm.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"mk@semihalf.com" <mk@semihalf.com>,
"Tzalik, Guy" <gtzalik@amazon.com>,
"Schmeilin, Evgeny" <evgenys@amazon.com>,
"mw@semihalf.com" <mw@semihalf.com>,
"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
"ruifeng.wang@arm.com" <ruifeng.wang@arm.com>,
"phil.yang@arm.com" <phil.yang@arm.com>,
"joyce.kong@arm.com" <joyce.kong@arm.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>
Subject: Re: [dpdk-dev] [PATCH RFC v1 0/7] relax barriers for ENA PMD and small fixes
Date: Wed, 15 Apr 2020 16:27:59 +0100 [thread overview]
Message-ID: <1769b276-b686-4184-6f94-d6fe4a13db65@intel.com> (raw)
In-Reply-To: <10e90cbc7bbe4d84979dabcb0fbe0c41@EX13D12EUA003.ant.amazon.com>
On 3/16/2020 9:34 AM, Chauskin, Igor wrote:
> Hi Gavin,
>
> Thank you for the contribution.
> Please do not merge these changes (patches 0..7) till we (the ENA team) properly review and ack/nack.
Hi Igor,
Is there any progress on reviewing the set?
Thanks,
ferruh
> These changes can potentially provide performance improvement, yet we need to ensure they are applicable for all possible scenarios. Specifically, the behavior on x86 platforms is likely to be different.
> What testing have you done for these patches? Was x86 tested?
>
> Thanks,
> Igor
>
> -----Original Message-----
> From: Gavin Hu <gavin.hu@arm.com>
> Sent: Friday, March 13, 2020 11:18 AM
> To: dev@dpdk.org
> Cc: nd@arm.com; david.marchand@redhat.com; thomas@monjalon.net; mk@semihalf.com; Tzalik, Guy <gtzalik@amazon.com>; Schmeilin, Evgeny <evgenys@amazon.com>; Chauskin, Igor <igorch@amazon.com>; mw@semihalf.com; Honnappa.Nagarahalli@arm.com; ruifeng.wang@arm.com; phil.yang@arm.com; joyce.kong@arm.com
> Subject: [EXTERNAL][PATCH RFC v1 0/7] relax barriers for ENA PMD and small fixes
>
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
> To ensure the stores to the host memory are observed by NIC HW before a door bell ring to the NIC HW and the HW starts actions, for example, doing DMA, a barrier is required on weak memory ordering platforms, like aarch64.
>
> However, unnecessarily too strong barriers like 'dsb' on aarch64 will dampen performance.
>
> In a typical doorbell use case, as NIC and CPU are in the outer sharable domain, a lighter weight 'dmb osh' barrier is sufficient.
>
> The patch set relaxes the barriers in similar places and include one more patch for statistics logging with relaxed ordering and the other patch removing duplicate memset.
>
> Note this set is submitted for RFC as we don't have physical ENA NICs in the lab and the patch set was not verified nor benchmarked.
>
> Gavin Hu (7):
> net/ena: remove duplicate barrier
> net/ena: relax the barrier for doorbell ring
> net/ena: relax the rmb for DMA
> net/ena: relax barrier for completion queue update
> net/ena: relax the barrier for bounce buffer
> net/ena: use c11 atomic for statistics
> net/ena: remove duplicate memset
>
> drivers/net/ena/base/ena_eth_com.c | 2 +-
> drivers/net/ena/base/ena_eth_com.h | 6 ++--
> drivers/net/ena/base/ena_plat_dpdk.h | 2 +-
> drivers/net/ena/ena_ethdev.c | 46 +++++++++++++++++-----------
> drivers/net/ena/ena_ethdev.h | 8 ++---
> 5 files changed, 38 insertions(+), 26 deletions(-)
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-04-15 15:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 9:18 Gavin Hu
2020-03-13 9:18 ` [dpdk-dev] [PATCH RFC v1 1/7] net/ena: remove duplicate barrier Gavin Hu
2020-03-13 9:18 ` [dpdk-dev] [PATCH RFC v1 2/7] net/ena: relax the barrier for doorbell ring Gavin Hu
2020-03-13 9:18 ` [dpdk-dev] [PATCH RFC v1 3/7] net/ena: relax the rmb for DMA Gavin Hu
2020-03-13 9:18 ` [dpdk-dev] [PATCH RFC v1 4/7] net/ena: relax barrier for completion queue update Gavin Hu
2020-03-13 9:18 ` [dpdk-dev] [PATCH RFC v1 5/7] net/ena: relax the barrier for bounce buffer Gavin Hu
2020-03-13 9:18 ` [dpdk-dev] [PATCH RFC v1 6/7] net/ena: use c11 atomic for statistics Gavin Hu
2020-03-13 9:18 ` [dpdk-dev] [PATCH RFC v1 7/7] net/ena: remove duplicate memset Gavin Hu
2020-03-16 9:34 ` [dpdk-dev] [PATCH RFC v1 0/7] relax barriers for ENA PMD and small fixes Chauskin, Igor
2020-03-17 7:58 ` Gavin Hu
2020-04-16 13:37 ` Chauskin, Igor
2020-04-21 7:45 ` Gavin Hu
2020-05-12 21:22 ` Honnappa Nagarahalli
2020-04-15 15:27 ` Ferruh Yigit [this message]
2020-04-15 15:59 ` Chauskin, Igor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1769b276-b686-4184-6f94-d6fe4a13db65@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=gavin.hu@arm.com \
--cc=gtzalik@amazon.com \
--cc=igorch@amazon.com \
--cc=joyce.kong@arm.com \
--cc=matua@amazon.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=nd@arm.com \
--cc=phil.yang@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=saeedb@amazon.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).