patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: stable@dpdk.org, Ilya Maximets <i.maximets@samsung.com>,
	dev@dpdk.org, solal.pirelli@gmail.com
Subject: Re: [dpdk-stable] [PATCH v3] mem: fix undefined behavior in NUMA code
Date: Thu, 04 Oct 2018 00:36:47 +0200	[thread overview]
Message-ID: <1780284.rQHulcP352@xps> (raw)
In-Reply-To: <20180921110038eucas1p1185f3275e6d99f285f44a299dd3b210d~WZT3JUk-I2589925899eucas1p12@eucas1p1.samsung.com>

21/09/2018 13:02, Ilya Maximets:
> On 21.09.2018 12:27, Anatoly Burakov wrote:
> > When NUMA-aware hugepages config option is set, we rely on
> > libnuma to tell the kernel to allocate hugepages on a specific
> > NUMA node. However, we allocate node mask before we check if
> > NUMA is available in the first place, which, according to
> > the manpage [1], causes undefined behaviour.
> > 
> > Fix by only using nodemask when we have NUMA available.
> > 
> > [1] https://linux.die.net/man/3/numa_alloc_onnode
> > 
> > Bugzilla ID: 20
> > 
> > Fixes: 1b72605d2416 ("mem: balanced allocation of hugepages")
> > Cc: i.maximets@samsung.com
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
> > 
> > Notes:
> >     v3:
> >     - Fix potential memory leak if socket-mem was not specified
> >     
> >     v2:
> >     - Improve readability as per Ilya's comment
> > 
> >  lib/librte_eal/linuxapp/eal/eal_memory.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> LGTM,
> Acked-by: Ilya Maximets <i.maximets@samsung.com>

Applied, thanks

      reply	other threads:[~2018-10-03 22:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180829122139epcas1p13ad45026365d788c072f2ed7a38349fb@epcas1p1.samsung.com>
2018-08-29 12:21 ` [dpdk-stable] [PATCH] " Anatoly Burakov
2018-08-29 13:02   ` Ilya Maximets
2018-09-20 12:50   ` [dpdk-stable] [PATCH v2] " Anatoly Burakov
2018-09-21  6:47     ` Ilya Maximets
2018-09-21  8:57       ` Burakov, Anatoly
2018-09-21  9:27     ` [dpdk-stable] [PATCH v3] " Anatoly Burakov
2018-09-21 11:02       ` Ilya Maximets
2018-10-03 22:36         ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1780284.rQHulcP352@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=i.maximets@samsung.com \
    --cc=solal.pirelli@gmail.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).