From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Helin Zhang <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/5] ethdev: add new ops of 'check_command_supported' and 'rx_classification_filter_ctl'
Date: Thu, 24 Jul 2014 09:56:32 +0200 [thread overview]
Message-ID: <1794712.d8vW817aRs@xps13> (raw)
In-Reply-To: <1406184149-11531-3-git-send-email-helin.zhang@intel.com>
2014-07-24 14:42, Helin Zhang:
> Two ops of 'check_command_supported' and 'rx_classification_filter_ctl'
> are added.
> * 'check_command_supported' is for capability discovery. In anothoer
> word, it is to check if specific feature/command is supported by
> the specific port.
This generic service is really needed to add NIC-specific functions.
I'd suggest to name it "is_supported".
> * 'rx_classification_filter_ctl' is for receive classifcation filter
> configuring. e.g. hash function configuration, flow director
> configuration. It is a common API where a lot of commands can
> be implemented for different sub features.
Not sure about this one. You are hiding specific API in an opaque structure.
By the way, it should be in another patch.
> +/**
> + * Check if the command is supported by an Ethernet device.
> + *
> + * @param port_id
> + * The port identifier of the Ethernet device.
> + * @param cmd
> + * The command.
> + *
> + * @return
> + * - (> 0) The command is supported.
> + * - (0) The command is not supported.
> + * - (-ENOTSUP) if hardware doesn't support.
> + * - (-ENODEV) if <port_id> is invalid.
> + */
> +int rte_eth_dev_check_command_supported(uint8_t port_id, uint32_t cmd);
What are the possible commands?
You should define enum/constants here.
--
Thomas
next prev parent reply other threads:[~2014-07-24 7:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 6:42 [dpdk-dev] [PATCH 0/5] Support configuring hash functions Helin Zhang
2014-07-24 6:42 ` [dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet classification type Helin Zhang
2014-07-24 7:48 ` Thomas Monjalon
2014-07-24 8:14 ` Zhang, Helin
2014-07-24 8:19 ` Thomas Monjalon
2014-07-24 8:23 ` Zhang, Helin
2014-07-24 6:42 ` [dpdk-dev] [PATCH 2/5] ethdev: add new ops of 'check_command_supported' and 'rx_classification_filter_ctl' Helin Zhang
2014-07-24 7:56 ` Thomas Monjalon [this message]
2014-07-24 8:49 ` Zhang, Helin
2014-07-24 6:42 ` [dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions Helin Zhang
2014-07-24 7:59 ` Thomas Monjalon
2014-07-24 8:01 ` Matthew Hall
2014-07-24 8:07 ` Thomas Monjalon
2014-07-24 8:14 ` Matthew Hall
2014-07-24 8:54 ` Zhang, Helin
2014-07-24 6:42 ` [dpdk-dev] [PATCH 4/5] i40e: support configuring symmetric hash function Helin Zhang
2014-07-24 6:42 ` [dpdk-dev] [PATCH 5/5] app/testpmd: new commands for configuring hash functions Helin Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1794712.d8vW817aRs@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).