From: santosh <santosh.shukla@caviumnetworks.com>
To: Yuanhan Liu <yliu@fridaylinux.org>,
Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, olivier.matz@6wind.com, shreyansh.jain@nxp.com,
stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] test/test_mbuf: remove mempool global var
Date: Thu, 22 Jun 2017 11:01:30 +0530 [thread overview]
Message-ID: <17cd00c1-abda-84e8-d394-ab72264d8022@caviumnetworks.com> (raw)
In-Reply-To: <20170620082256.GA436@yliu-home>
Hi Yuanhan,
On Tuesday 20 June 2017 01:52 PM, Yuanhan Liu wrote:
> On Tue, Jun 20, 2017 at 09:35:07AM +0200, Thomas Monjalon wrote:
>> 20/06/2017 06:14, santosh:
>>> On Tuesday 20 June 2017 02:07 AM, Thomas Monjalon wrote:
>>>
>>>> 08/06/2017 16:28, Santosh Shukla:
>>>>> Let test_mbuf alloc and free mempool.
>>>>>
>>>>> Cc: stable@dpdk.org
>>>>> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
>>>> Why Cc stable?
>>>> Is it fixing something?
>>>>
>>> w/o this fix, application can't run more than once.
>>> Reason: Static allocation of resources and exiting w/o freeing so leak.
>>>
>>> Patch makes app resource handling dynamic and Now user could run
>>> test more than once and app exits gracefully. thats why Cc: stable a need (IHMO).
>>> Thanks.
>> OK
>> So we need a Fixes: tag in order to be able to guess which
>> release it should be backported to.
> Also, I would suggest you to include above info (the real issue) in
> the commit log.
>
> --yliu
Yes, We'll reword and post v3 but won't be a stable candidate.
next prev parent reply other threads:[~2017-06-22 5:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 14:28 [dpdk-stable] " Santosh Shukla
2017-06-16 14:35 ` Olivier Matz
2017-06-19 20:37 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2017-06-20 4:14 ` santosh
2017-06-20 7:35 ` Thomas Monjalon
2017-06-20 8:22 ` Yuanhan Liu
2017-06-22 5:31 ` santosh [this message]
2017-06-22 5:29 ` santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17cd00c1-abda-84e8-d394-ab72264d8022@caviumnetworks.com \
--to=santosh.shukla@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=shreyansh.jain@nxp.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).