From: zhoumin <zhoumin@loongson.cn>
To: Aaron Conole <aconole@redhat.com>
Cc: ci@dpdk.org, msantana@redhat.com, dmarchan@redhat.com,
thomas@monjalon.net, probb@iol.unh.edu, dceara@redhat.com,
alialnu@nvidia.com
Subject: Re: [PATCH v1] tools: fix parsing message-id in the headers of email
Date: Thu, 14 Dec 2023 02:36:34 +0000 [thread overview]
Message-ID: <17ce7bbc-e5e3-039f-a5fa-c9c8990bdee3@loongson.cn> (raw)
In-Reply-To: <f7tv892s1p8.fsf@redhat.com>
On Wed, Dec 13, 2023 at 12:53PM, Aaron Conole wrote:
> zhoumin <zhoumin@loongson.cn> writes:
>
>> Hi Aaron,
>>
>> Thanks for your reply.
>>
>> On Thur, Dec 7, 2023 7:07PM, Aaron Conole wrote:
>>> Min Zhou <zhoumin@loongson.cn> writes:
>>>
>>>> Some email has the message-id header named "Message-id", like this:
>>>> https://patches.dpdk.org/project/dpdk/patch/20230930010024.34377-1-rdna@apple.com/.
>>>> So add the parsing for this kind of email.
>>>>
>>>> Signed-off-by: Min Zhou <zhoumin@loongson.cn>
>>>> ---
>>> Hi Min,
>>>
>>> I wonder - we will keep having this issue of these header fields being
>>> incorrectly matched based on case issues.
>>>
>>> Maybe we should make getheader have the ability to ignore case, or pass
>>> something like Message-[iI][dD] as the header argument.
>>>
>>> WDYT?
>> Yes, making getheader have the ability to ignore case is simple and
>> does work for this case as following:
>>
>> diff --git a/tools/parse-email.sh b/tools/parse-email.sh
>> index 9ab627b..1e3008a 100755
>> --- a/tools/parse-email.sh
>> +++ b/tools/parse-email.sh
>> @@ -29,7 +29,7 @@ fi
>>
>> getheader () # <header_name> <email_file>
>> {
>> - sed "/^$1: */!d;s///;N;s,\n[[:space:]]\+, ,;s,\n.*,,;q" "$2" |
>> + sed "/^$1: */I!d;s///;N;s,\n[[:space:]]\+, ,;s,\n.*,,;q" "$2" |
>> sed 's,",\\",g'
>>
>> }
>>
>> But, I think we might get a false-positive when matching header field
>> by this way. Because we are handling the whole patch file which could
>> have same words in somewhere if we ignore the case.
>>
>> Passing Message-[iI][dD] also works for this case and I tend to use
>> this method. What do you think? If you agree with this method I will
>> send the V2 patch.
> ACK by me - sounds good. That means we can just modify the existing
> getheader check for message id.
Yes, thanks! I will send the V2 patch.
Best regards,
Min
>> Best regards,
>>
>> Min
>>
>>
>>>> tools/parse-email.sh | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/tools/parse-email.sh b/tools/parse-email.sh
>>>> index 9cb9583..fbe038a 100755
>>>> --- a/tools/parse-email.sh
>>>> +++ b/tools/parse-email.sh
>>>> @@ -35,6 +35,7 @@ subject=$(getheader Subject "$1")
>>>> from=$(getheader From "$1")
>>>> msgid=$(getheader Message-Id "$1")
>>>> [ -n "$msgid" ] || msgid=$(getheader Message-ID "$1")
>>>> +[ -n "$msgid" ] || msgid=$(getheader Message-id "$1")
>>>> pwid=$(getheader X-Patchwork-Id "$1")
>>>> listid=$(getheader List-Id "$1")
>>>> reply=$(getheader In-Reply-To "$1")
prev parent reply other threads:[~2023-12-14 2:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 2:52 Min Zhou
2023-12-07 19:07 ` Aaron Conole
2023-12-08 3:53 ` zhoumin
2023-12-13 12:53 ` Aaron Conole
2023-12-14 2:36 ` zhoumin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17ce7bbc-e5e3-039f-a5fa-c9c8990bdee3@loongson.cn \
--to=zhoumin@loongson.cn \
--cc=aconole@redhat.com \
--cc=alialnu@nvidia.com \
--cc=ci@dpdk.org \
--cc=dceara@redhat.com \
--cc=dmarchan@redhat.com \
--cc=msantana@redhat.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).