From: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [RFC 0/1] A Distributed Software Event Device
Date: Fri, 13 Jul 2018 19:21:56 +0200 [thread overview]
Message-ID: <17ce95f7-ac9b-3bd3-fb5a-4e1abbd18bc9@ericsson.com> (raw)
In-Reply-To: <9D0047EC-F089-4FD5-99C7-9E611743EFD7@intel.com>
On 2018-07-12 22:39, Wiles, Keith wrote:
>
>
>> On Jul 11, 2018, at 4:21 PM, Mattias Rönnblom <mattias.ronnblom@ericsson.com> wrote:
>>
>> This is the Distributed Software (DSW) event device, which distributes
>> the task of scheduling events among all the eventdev ports and their
>> lcore threads.
>>
>> DSW is primarily designed for atomic-only queues, but also supports
>> single-link and parallel queues.
>>
>> (DSW would be more accurately described as 'parallel', but since that
>> term is used to describe an eventdev queue type, it's referred to as
>> 'distributed', to avoid suggesting it's somehow biased toward parallel
>> queues.)
>>
>>
>
> Just a quick look at the format of the code I notice a number of places missing a blank line after the declarations in a function e.g. dsw_xstats_port_get() an others. Just to help when you send this in as a real patch. Make sure you run checkpatch.
>
> As for the RFC I like the idea of this RFC, but need to dig into the code.
>
I did run checkpatch (w/ a checkpatch.pl from a newly cloned Linux
kernel tree), but it didn't catch this.
I'll fix it. Thanks.
Regards,
Mattias
prev parent reply other threads:[~2018-07-13 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 21:21 Mattias Rönnblom
2018-07-11 21:21 ` [dpdk-dev] [RFC 1/1] eventdev: add distributed software (DSW) event device Mattias Rönnblom
2018-07-12 20:39 ` [dpdk-dev] [RFC 0/1] A Distributed Software Event Device Wiles, Keith
2018-07-13 17:21 ` Mattias Rönnblom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17ce95f7-ac9b-3bd3-fb5a-4e1abbd18bc9@ericsson.com \
--to=mattias.ronnblom@ericsson.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).