From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Reshma Pattan <reshma.pattan@intel.com>,
thomas@monjalon.net, dev@dpdk.org
Cc: jananeex.m.parthasarathy@intel.com, stable@dpdk.org,
ferruh.yigit@intel.com
Subject: Re: [dpdk-stable] [PATCH v5 10/10] mk: remove unnecessary make rules of test
Date: Wed, 18 Jul 2018 09:56:35 +0100 [thread overview]
Message-ID: <17f96606-377c-4eaa-92e9-ab1b57465cd7@intel.com> (raw)
In-Reply-To: <1531843225-14638-11-git-send-email-reshma.pattan@intel.com>
On 17-Jul-18 5:00 PM, Reshma Pattan wrote:
> make rule test-basic is duplicate of test rule.
> removed unused test-mempool and test-ring make rules.
>
> Fixes: a3df7f8d9c ("mk: rename test related rules")
> Fixes: a3df7f8d9c ("mk: rename test related rules")
Fixline appears two times :) Thomas can fix it on apply though.
> CC: stable@dpdk.org
> CC: ferruh.yigit@intel.com
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> mk/rte.sdkroot.mk | 4 ++--
> mk/rte.sdktest.mk | 7 +++----
> 2 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk
> index ea3473ebf..18c88017e 100644
> --- a/mk/rte.sdkroot.mk
> +++ b/mk/rte.sdkroot.mk
> @@ -68,8 +68,8 @@ config defconfig showconfigs showversion showversionum:
> cscope gtags tags etags:
> $(Q)$(RTE_SDK)/devtools/build-tags.sh $@ $T
>
> -.PHONY: test test-basic test-fast test-ring test-mempool test-perf coverage test-drivers test-dump
> -test test-basic test-fast test-ring test-mempool test-perf coverage test-drivers test-dump:
> +.PHONY: test test-fast test-perf coverage test-drivers test-dump
> +test test-fast test-perf coverage test-drivers test-dump:
> $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdktest.mk $@
>
> test: test-build
> diff --git a/mk/rte.sdktest.mk b/mk/rte.sdktest.mk
> index 13d1efb6a..295592809 100644
> --- a/mk/rte.sdktest.mk
> +++ b/mk/rte.sdktest.mk
> @@ -18,7 +18,7 @@ DIR := $(shell basename $(RTE_OUTPUT))
> #
> # test: launch auto-tests, very simple for now.
> #
> -.PHONY: test test-basic test-fast test-perf test-drivers test-dump coverage
> +.PHONY: test test-fast test-perf test-drivers test-dump coverage
>
> PERFLIST=ring_perf,mempool_perf,memcpy_perf,hash_perf,timer_perf,\
> reciprocal_division,reciprocal_division_perf,lpm_perf,red_all,\
> @@ -31,8 +31,7 @@ DRIVERSLIST=link_bonding,link_bonding_mode4,link_bonding_rssconf,\
> cryptodev_scheduler,cryptodev_aesni_gcm,cryptodev_null,\
> cryptodev_sw_snow3g,cryptodev_sw_kasumi,cryptodev_sw_zuc
> DUMPLIST=dump_struct_sizes,dump_mempool,dump_malloc_stats,dump_devargs,\
> - dump_log_types,dump_ring,quit,dump_physmem,dump_memzone,\
> - devargs_autotest
> + dump_log_types,dump_ring,dump_physmem,dump_memzone
>
> SPACESTR:=
> SPACESTR+=
> @@ -46,7 +45,7 @@ test-perf: WHITELIST=$(STRIPPED_PERFLIST)
> test-drivers: WHITELIST=$(STRIPPED_DRIVERSLIST)
> test-dump: WHITELIST=$(STRIPPED_DUMPLIST)
>
> -test test-basic test-fast test-perf test-drivers test-dump:
> +test test-fast test-perf test-drivers test-dump:
> @mkdir -p $(AUTOTEST_DIR) ; \
> cd $(AUTOTEST_DIR) ; \
> if [ -f $(RTE_OUTPUT)/app/test ]; then \
>
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-07-18 8:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1531843225-14638-1-git-send-email-reshma.pattan@intel.com>
2018-07-17 16:00 ` [dpdk-stable] [PATCH v5 01/10] autotest: fix printing Reshma Pattan
2018-07-17 16:00 ` [dpdk-stable] [PATCH v5 02/10] autotest: fix invalid code on reports Reshma Pattan
2018-07-17 16:00 ` [dpdk-stable] [PATCH v5 03/10] autotest: make autotest runner python 2/3 compliant Reshma Pattan
2018-07-17 16:00 ` [dpdk-stable] [PATCH v5 04/10] autotest: visually separate different test categories Reshma Pattan
2018-07-17 16:00 ` [dpdk-stable] [PATCH v5 05/10] autotest: improve filtering Reshma Pattan
2018-07-17 16:00 ` [dpdk-stable] [PATCH v5 07/10] autotest: properly parallelize unit tests Reshma Pattan
2018-07-17 16:00 ` [dpdk-stable] [PATCH v5 08/10] autotest: update autotest test case list Reshma Pattan
2018-07-17 16:00 ` [dpdk-stable] [PATCH v5 09/10] mk: update make targets for classified testcases Reshma Pattan
2018-07-18 8:55 ` Burakov, Anatoly
2018-07-17 16:00 ` [dpdk-stable] [PATCH v5 10/10] mk: remove unnecessary make rules of test Reshma Pattan
2018-07-18 8:56 ` Burakov, Anatoly [this message]
2018-07-26 20:08 ` Thomas Monjalon
2018-07-27 8:22 ` Pattan, Reshma
2018-07-27 8:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17f96606-377c-4eaa-92e9-ab1b57465cd7@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).