From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/tap: fix invalid queue file descriptor
Date: Mon, 30 Jan 2017 20:57:38 +0000 [thread overview]
Message-ID: <180E842F-5344-4E7D-B46E-6A58232A680F@intel.com> (raw)
In-Reply-To: <20170130205445.7527-1-ferruh.yigit@intel.com>
> On Jan 30, 2017, at 2:54 PM, Yigit, Ferruh <ferruh.yigit@intel.com> wrote:
>
> From: Keith Wiles <keith.wiles@intel.com>
>
> Rx and Tx queues share the common tap file descriptor, but save this
> value separately.
>
> Setting up Rx/Tx queue sets up both queues, release_queue close the
> tap file but update file descriptor only for that queue.
>
> This makes other queue's file descriptor invalid.
>
> As a workaround, prevent release_queue callback to be called by default.
>
> This is done by separating Rx/Tx setup functions, so that each only
> setup its own queue, this prevents rte_eth_rx/tx_queue_setup() calling
> release_queue before setup_queue.
>
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Keith Wiles <keith.wiles@intel.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 26 ++++++++++++++++++++++----
> 1 file changed, 22 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index c0afc2d..91f63f5 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -428,8 +428,6 @@ tap_setup_queue(struct rte_eth_dev *dev,
> }
> }
> }
> - dev->data->rx_queues[qid] = rx;
> - dev->data->tx_queues[qid] = tx;
>
> rx->fd = fd;
> tx->fd = fd;
> @@ -438,6 +436,26 @@ tap_setup_queue(struct rte_eth_dev *dev,
> }
>
> static int
> +rx_setup_queue(struct rte_eth_dev *dev,
> + struct pmd_internals *internals,
> + uint16_t qid)
> +{
> + dev->data->rx_queues[qid] = &internals->rxq[qid];
> +
> + return tap_setup_queue(dev, internals, qid);
> +}
> +
> +static int
> +tx_setup_queue(struct rte_eth_dev *dev,
> + struct pmd_internals *internals,
> + uint16_t qid)
> +{
> + dev->data->tx_queues[qid] = &internals->txq[qid];
> +
> + return tap_setup_queue(dev, internals, qid);
> +}
> +
> +static int
> tap_rx_queue_setup(struct rte_eth_dev *dev,
> uint16_t rx_queue_id,
> uint16_t nb_rx_desc __rte_unused,
> @@ -469,7 +487,7 @@ tap_rx_queue_setup(struct rte_eth_dev *dev,
> return -ENOMEM;
> }
>
> - fd = tap_setup_queue(dev, internals, rx_queue_id);
> + fd = rx_setup_queue(dev, internals, rx_queue_id);
> if (fd == -1)
> return -1;
>
> @@ -493,7 +511,7 @@ tap_tx_queue_setup(struct rte_eth_dev *dev,
> if (tx_queue_id >= internals->nb_queues)
> return -1;
>
> - ret = tap_setup_queue(dev, internals, tx_queue_id);
> + ret = tx_setup_queue(dev, internals, tx_queue_id);
> if (ret == -1)
> return -1;
>
> --
> 2.9.3
>
Regards,
Keith
next prev parent reply other threads:[~2017-01-30 20:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-29 2:12 [dpdk-dev] [PATCH] net/tap: driver closing tx interface on queue setup Keith Wiles
2017-01-30 11:00 ` Ferruh Yigit
2017-01-30 14:34 ` Wiles, Keith
2017-01-30 17:42 ` Ferruh Yigit
2017-01-30 18:20 ` Wiles, Keith
2017-01-30 19:31 ` Ferruh Yigit
2017-01-30 14:38 ` Pascal Mazon
2017-01-30 15:04 ` Wiles, Keith
2017-01-30 17:19 ` Ferruh Yigit
2017-01-30 20:54 ` [dpdk-dev] [PATCH v2] net/tap: fix invalid queue file descriptor Ferruh Yigit
2017-01-30 20:57 ` Wiles, Keith [this message]
2017-01-30 21:23 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=180E842F-5344-4E7D-B46E-6A58232A680F@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).