From: Thomas Monjalon <thomas@monjalon.net>
To: Hemant Agrawal <hemant.agrawal@nxp.com>, anatoly.burakov@intel.com
Cc: dev@dpdk.org, shreyansh.jain@nxp.com
Subject: Re: [dpdk-dev] [PATCH 01/2] vfio: expose clear group function for internal usages
Date: Fri, 12 Jan 2018 17:36:14 +0100 [thread overview]
Message-ID: <1811467.p4hthpzDLK@xps> (raw)
In-Reply-To: <1512642493-14609-1-git-send-email-hemant.agrawal@nxp.com>
07/12/2017 11:28, Hemant Agrawal:
> other vfio based module e.g. fslmc will also need to use
> the clear_group call.
> So, exposing it and renaming it to *rte_vfio_clear_group*
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> --- a/lib/librte_eal/linuxapp/eal/eal_vfio.h
> +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.h
> @@ -179,7 +179,7 @@ vfio_get_group_fd(int iommu_group_no);
>
> /* remove group fd from internal VFIO group fd array */
> int
> -clear_group(int vfio_group_fd);
> +rte_vfio_clear_group(int vfio_group_fd);
The function should be moved to lib/librte_eal/common/include/rte_vfio.h
and an empty implementation must be added for BSD.
Related note: in drivers/bus/fslmc/fslmc_vfio.h there is
#include "eal_vfio.h"
Can it be removed?
next prev parent reply other threads:[~2018-01-12 16:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 10:28 Hemant Agrawal
2017-12-07 10:28 ` [dpdk-dev] [PATCH 02/2] bus/fslmc: clear the vfio group on error Hemant Agrawal
2018-01-12 15:27 ` [dpdk-dev] [PATCH 01/2] vfio: expose clear group function for internal usages Burakov, Anatoly
2018-01-12 16:36 ` Thomas Monjalon [this message]
2018-01-14 13:05 ` Hemant Agrawal
2018-01-15 5:11 ` [dpdk-dev] [PATCH v2 1/2] " Hemant Agrawal
2018-01-15 5:11 ` [dpdk-dev] [PATCH v2 2/2] bus/fslmc: clear the vfio group on error Hemant Agrawal
2018-01-16 23:43 ` [dpdk-dev] [PATCH v2 1/2] vfio: expose clear group function for internal usages Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1811467.p4hthpzDLK@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).