From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] malloc: fix finding maximum contiguous IOVA size
Date: Wed, 12 Dec 2018 11:26:07 +0000 [thread overview]
Message-ID: <1812ed89-fc60-1298-d789-201bd8a80471@intel.com> (raw)
In-Reply-To: <20181212111054.35935-1-yskoh@mellanox.com>
On 12-Dec-18 11:10 AM, Yongseok Koh wrote:
> malloc_elem_find_max_iova_contig() could return invalid size due to a
> missing sanity check. The following gdb output shows how 'cur_size' can be
> invalid in find_biggest_element().
>
> (gdb) p/x cur_size
> $4 = 0xffffffffffe42900
> (gdb) p elem
> $1 = (struct malloc_elem *) 0x12e842000
> (gdb) p *elem
> $2 = {heap = 0x7ffff7ff387c, prev = 0x12e831fc0, next =
> 0x12e842900, free_list = {le_next = 0x109538000, le_prev =
> 0x7ffff7ff3894}, msl = 0x7ffff7ff107c, state = ELEM_FREE,
> pad = 0, size = 2304}
> (gdb) p *elem->msl
> $5 = {{base_va = 0x100200000, addr_64 = 4297064448}, page_sz =
> 2097152, socket_id = 0, version = 790, len = 17179869184,
> external = 0, memseg_arr = {name = "memseg-2048k-0-0",
> '\000' <repeats 47 times>, count = 493, len = 8192, elt_sz
> = 48, data = 0x10002e000, rwlock = {cnt = 0}}}
>
> Fixes: 9fe6bceafd51 ("malloc: add finding biggest free IOVA-contiguous element")
> Cc: stable@dpdk.org
> Cc: anatoly.burakov@intel.com
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-12-12 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 11:10 Yongseok Koh
2018-12-12 11:26 ` Burakov, Anatoly [this message]
2018-12-20 14:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1812ed89-fc60-1298-d789-201bd8a80471@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).