From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Mike Pattrick <mkp@redhat.com>, dev@dpdk.org
Cc: david.marchand@redhat.com, chenbo.xia@intel.com
Subject: Re: [PATCH v3] vhost: fix madvise arguments alignment
Date: Mon, 6 Mar 2023 15:22:16 +0100 [thread overview]
Message-ID: <181baa4c-97fd-95a0-537b-f7f1643cf42e@redhat.com> (raw)
In-Reply-To: <20230301200228.1477189-1-mkp@redhat.com>
On 3/1/23 21:02, Mike Pattrick wrote:
> The arguments passed to madvise should be aligned to the alignment of
> the backing memory. Now we keep track of each regions alignment and use
> then when setting coredump preferences. To facilitate this, a new member
> was added to rte_vhost_mem_region. A new function was added to easily
> translate memory address back to region alignment. Unneeded calls to
> madvise were reduced, as the cache removal case should already be
> covered by the cache insertion case. The previously inline function
> mem_set_dump was removed from a header file and made not inline.
>
> Fixes: 338ad77c9ed3 ("vhost: exclude VM hugepages from coredumps")
>
> Signed-off-by: Mike Pattrick <mkp@redhat.com>
> ---
> Since v1:
> - Corrected a cast for 32bit compiles
> Since v2:
> - Removed changes from rte_vhost.h
> - Restored set_mem_dump in ioctl remove/evict functions
> ---
> lib/vhost/iotlb.c | 68 +++++++++++++++++++++++++++++++-----------
> lib/vhost/iotlb.h | 5 ++--
> lib/vhost/vhost.h | 12 ++------
> lib/vhost/vhost_user.c | 68 ++++++++++++++++++++++++++++++++++--------
> 4 files changed, 110 insertions(+), 43 deletions(-)
>
Applied to dpdk-next-virtio/main.
Thanks,
Maxime
next prev parent reply other threads:[~2023-03-06 14:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 15:05 [PATCH v2] vhost: exclude VM hugepages from coredumps Mike Pattrick
2022-12-07 16:54 ` [PATCH v3] " Mike Pattrick
2022-12-20 12:43 ` Maxime Coquelin
2023-02-03 14:50 ` Maxime Coquelin
2023-02-10 15:53 ` David Marchand
2023-02-10 15:59 ` Maxime Coquelin
2023-02-10 21:12 ` Mike Pattrick
2023-02-21 16:26 ` Maxime Coquelin
2023-02-22 13:59 ` Mike Pattrick
2023-02-22 21:43 ` [PATCH] vhost: fix madvise arguments alignment Mike Pattrick
2023-02-23 4:35 ` [PATCH v2] " Mike Pattrick
2023-02-23 16:12 ` Maxime Coquelin
2023-02-23 16:57 ` Mike Pattrick
2023-02-24 15:05 ` Patrick Robb
2023-03-01 20:02 ` [PATCH v3] " Mike Pattrick
2023-03-02 10:19 ` Maxime Coquelin
2023-03-06 14:22 ` Maxime Coquelin [this message]
2023-02-03 17:45 ` [PATCH v2] vhost: exclude VM hugepages from coredumps Stephen Hemminger
2023-02-06 1:13 ` Mike Pattrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=181baa4c-97fd-95a0-537b-f7f1643cf42e@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mkp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).