From: Thomas Monjalon <thomas@monjalon.net>
To: Aaron Conole <aconole@redhat.com>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
Jeff Guo <jia.guo@intel.com>
Subject: Re: [dpdk-dev] [PATCH] test/interrupt: account for race with callback
Date: Fri, 13 Sep 2019 17:01:35 +0200 [thread overview]
Message-ID: <1822498.zNlbTz1IHE@xps> (raw)
In-Reply-To: <CAJFAV8xo5wUUWu4szjh--YinA7LaKOibkcaURbTPbGkcna1VtQ@mail.gmail.com>
09/08/2019 11:18, David Marchand:
> On Thu, Aug 8, 2019 at 7:38 PM Aaron Conole <aconole@redhat.com> wrote:
> >
> > Because the eal interrupt framework can race when invoking the callback
> > and a separate unregister call, the test needs to accommodate the chance
> > that the two collide. Do this by checking the return value of unregister
> > against the race-condition flag (EAGAIN).
> >
> > Fixes: f1a6c22424ce ("app/test: update interrupts test")
>
> Not too sure about this tag, but anyway, this is old enough to apply
> to every stable releases we have.
> Cc: stable@dpdk.org ?
>
> > Signed-off-by: Aaron Conole <aconole@redhat.com>
> > ---
> > NOTE: it's difficult to reproduce this race. I tried a bit, but have
> > only seen it sporadically. In Travis environment, the CPU
> > resource can be very limited and this test is quite racy.
>
> Managed to reproduce it:
>
> # time (log=/tmp/$$.log; while true; do echo interrupt_autotest
> |taskset -c 0-1 ./build-gcc-static/app/test/dpdk-test -l 0-1 >$log
> 2>&1; grep -q 'Test OK' $log || break; done; cat $log; rm -f $log)
> EAL: Detected 8 lcore(s)
> EAL: Detected 1 NUMA nodes
> EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
> EAL: Selected IOVA mode 'PA'
> EAL: No available hugepages reported in hugepages-1048576kB
> EAL: Probing VFIO support...
> EAL: PCI device 0000:00:1f.6 on NUMA socket -1
> EAL: Invalid NUMA socket, default to 0
> EAL: probe driver: 8086:15d7 net_e1000_em
> APP: HPET is not enabled, using TSC as default timer
> RTE>>interrupt_autotest
> Check unknown valid interrupt full path
> Check valid UIO interrupt full path
> Check valid device event interrupt full path
> count=-11 Resource temporarily unavailable
> failure occurred during checking valid device event interrupt full path
> Clearing for interrupt tests
> Test Failed
> RTE>>
> real 0m38.081s
> user 0m35.836s
> sys 0m2.171s
>
> With this patch, my loop has been running for more than 10 minutes now.
> Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks
next prev parent reply other threads:[~2019-09-13 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 17:38 Aaron Conole
2019-08-09 9:18 ` David Marchand
2019-09-13 15:01 ` Thomas Monjalon [this message]
2019-09-13 14:42 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1822498.zNlbTz1IHE@xps \
--to=thomas@monjalon.net \
--cc=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).