From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: viktorin@rehivetech.com
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Tomasz Kulasek <tomaszx.kulasek@intel.com>,
dev@dpdk.org, jianbo.liu@linaro.org
Subject: Re: [dpdk-dev] [PATCH] arm: detect NEON by RTE_MACHINE_CPUFLAG_NEON flag only
Date: Fri, 18 Mar 2016 14:49:57 +0100 [thread overview]
Message-ID: <18259292.OJteoyVp0E@xps13> (raw)
In-Reply-To: <20160318130019.4715e5d5@pcviktorin.fit.vutbr.cz>
2016-03-18 13:00, Jan Viktorin:
> The RTE_MACHINE_CPUFLAG_NEON was only a result of the gcc testing.
> However, the target CPU may not support NEON or the user can disable to
> use it (as it does not always improve the performance).
>
> The RTE_MACHINE_CPUFLAG_NEON detection is now based on both, the
> __ARM_NEON_FP feature from gcc and CONFIG_RTE_ARCH_ARM_NEON from
> the .config. The memcpy implemention is driven by
> RTE_MACHINE_CPUFLAG_NEON, so the reason to disable neon is hidden for
> the actual code.
>
> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> ---
>
> I can also include this one:
>
> examples/l3fwd/l3fwd_em.c:253:#elif defined(__ARM_NEON)
Yes please.
I will set my patch as superseded.
next prev parent reply other threads:[~2016-03-18 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 12:00 Jan Viktorin
2016-03-18 13:49 ` Thomas Monjalon [this message]
2016-03-18 14:11 ` Jan Viktorin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18259292.OJteoyVp0E@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianbo.liu@linaro.org \
--cc=tomaszx.kulasek@intel.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).