From: Thomas Monjalon <thomas@monjalon.net>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
Fangming Fang <Fangming.Fang@arm.com>,
"Power, Ciara" <ciara.power@intel.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"Ji, Kai" <kai.ji@intel.com>, Ruifeng Wang <Ruifeng.Wang@arm.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
Akhil Goyal <gakhil@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Ashwin Sekhar T K <asekhar@marvell.com>
Subject: Re: [EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID
Date: Tue, 20 Jun 2023 16:41:32 +0200 [thread overview]
Message-ID: <1827753.atdPhlSkOF@thomas> (raw)
In-Reply-To: <CO6PR18MB4484DB18AC976FC7D70D5950D858A@CO6PR18MB4484.namprd18.prod.outlook.com>
16/06/2023 11:38, Akhil Goyal:
> > > > > >
> > > > > > For info, this does not compile with
> > > > > > https://urldefense.proofpoint.com/v2/url?u=https-
> > 3A__git.gitlab.arm.com_arm-2Dreference-2Dsolutions_ipsec-
> > 2Dmb&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey3e
> > u68gBzn7DkPwuqhd6WNyo&m=g7xU0Pucoh3ZqU7RUlw8mhb-
> > zlRr9t6XI0UCQi5vEjEfcovdH8kkXIJ_O-_c5zeg&s=J-l3-
> > qBNnT5HJ7OGeu5iECPxB1jrpQ5iA01_AOC2Bac&e=
> > > > > > because Arm did not merge Intel's code correctly, and
> > > > > > imb_set_session() is missing while version is 1.4.0-dev.
> > > > > >
> > > > > > Anyway I hate this situation having 2 repos for the same thing.
> > > > > > Please merge Arm code in the original repository from Intel.
> > > > > >
> > > > > Is it possible to make Arm repo as main repo and modify DPDK
> > > > > documentation, if Intel not agreeing to include Arm code?
> > > > > Currently the Arm repo use case is broken.
> > > > > If it is not resolved soon, we can submit a patch to revert the
> > > > > patch which is breaking compilation. This need to be fixed by RC2.
> > > >
> > > > It would be better if the original repo can merge Arm changes. We will
> > > > keep regular sync with original repo in the current situation, the
> > > > next sync will be carried out earlier in Q3.
> > >
> > > Yes, it is better to keep original repo. But if Intel is not agreeing to it, We may
> > > need to find some alternate way to fix it.
> > > We need a sync as soon as possible, as with current Arm repo, DPDK
> > > compilation is broken.
> > >
> > > For now, we cannot merge anything in ipsec_mb driver till we fix the
> > > compilation With Arm repo - either by Arm repo sync or by reverting the
> > > patches.
> >
> > DPDK is supposed to use stable versions of the library (e.g. releases), not top of
> > main branch.
> > As described in README https://github.com/intel/intel-ipsec-mb#4-package-content , tip of
> > the main is NOT a release software version.
> > In case of ARM library clone, it is not clear what the latest stable version is.
> > As the Intel library version is bumped in the first stages of development for the
> > next release, it is advisable to avoid updating this version in ARM library, until a
> > new Intel intel-ipsec-mb version is released.
> > For now, the simplest solution is to revert the ARM library version to 1.3
> > (changing IMB_VERSION_NUM and IMB_VERSION_STR), until the ARM repo is
> > synced to Intel 1.4.0 (which has just been released).
> >
> Hi Pablo,
>
> The point of discussion here is to have a common repo for both Intel and Arm.
> We would have less control if there are 2 repos for same stuff.
> The point is if Intel is not willing to take Arm changes in the repo (preferred solution),
> Why not update documentation to make Arm one as default which is a
> super set of Intel and Arm repo? This will avoid problems going forward.
Pablo, how can we reconcile both projects in one repository please?
next prev parent reply other threads:[~2023-06-20 14:41 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 13:12 [PATCH 0/8] add AESNI_MB optimisations Ciara Power
2023-04-21 13:12 ` [PATCH 1/8] crypto/ipsec_mb: use GMAC dedicated algorithms Ciara Power
2023-04-21 13:12 ` [PATCH 2/8] crypto/ipsec_mb: use burst API in aesni_mb Ciara Power
2023-04-21 13:12 ` [PATCH 3/8] crypto/ipsec_mb: use new SGL API Ciara Power
2023-04-21 13:12 ` [PATCH 4/8] crypto/ipsec_mb: remove unneeded fields in crypto session Ciara Power
2023-04-21 13:12 ` [PATCH 5/8] crypto/ipsec_mb: store template job Ciara Power
2023-04-21 13:12 ` [PATCH 6/8] crypto/ipsec_mb: optimize for GCM case Ciara Power
2023-04-21 13:12 ` [PATCH 7/8] crypto/ipsec_mb: do not free linear_sgl always Ciara Power
2023-04-21 13:12 ` [PATCH 8/8] crypto/ipsec_mb: set and use session ID Ciara Power
2024-02-22 20:52 ` Wathsala Wathawana Vithanage
2023-05-16 12:25 ` [EXT] [PATCH 0/8] add AESNI_MB optimisations Akhil Goyal
2023-05-16 12:54 ` Power, Ciara
2023-05-16 15:24 ` [PATCH v2 " Ciara Power
2023-05-16 15:24 ` [PATCH v2 1/8] crypto/ipsec_mb: use GMAC dedicated algorithms Ciara Power
2023-05-16 15:24 ` [PATCH v2 2/8] crypto/ipsec_mb: use burst API in aesni_mb Ciara Power
2023-05-16 15:24 ` [PATCH v2 3/8] crypto/ipsec_mb: use new SGL API Ciara Power
2023-05-16 15:24 ` [PATCH v2 4/8] crypto/ipsec_mb: remove unneeded fields in crypto session Ciara Power
2023-05-16 15:24 ` [PATCH v2 5/8] crypto/ipsec_mb: store template job Ciara Power
2023-05-16 15:24 ` [PATCH v2 6/8] crypto/ipsec_mb: optimize for GCM case Ciara Power
2023-05-16 15:24 ` [PATCH v2 7/8] crypto/ipsec_mb: do not free linear_sgl always Ciara Power
2023-05-16 15:24 ` [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID Ciara Power
2023-06-10 20:15 ` Thomas Monjalon
2023-06-14 5:35 ` [EXT] " Akhil Goyal
2023-06-15 2:46 ` Fangming Fang
2023-06-15 4:47 ` Akhil Goyal
2023-06-16 9:25 ` De Lara Guarch, Pablo
2023-06-16 9:38 ` Akhil Goyal
2023-06-20 6:32 ` Fangming Fang
2024-02-21 5:01 ` Patrick Robb
2024-02-21 5:10 ` [EXT] " Honnappa Nagarahalli
2024-02-21 5:23 ` Patrick Robb
2024-02-21 9:50 ` Power, Ciara
2024-02-21 19:09 ` Patrick Robb
2024-02-22 1:55 ` [EXT] " Wathsala Wathawana Vithanage
2024-02-26 23:23 ` Wathsala Wathawana Vithanage
2024-02-27 1:05 ` Patrick Robb
2024-02-27 6:13 ` Akhil Goyal
2024-03-05 17:36 ` Wathsala Wathawana Vithanage
2023-06-20 14:41 ` Thomas Monjalon [this message]
2023-06-21 19:11 ` De Lara Guarch, Pablo
2023-05-17 16:44 ` [PATCH v2 0/8] add AESNI_MB optimisations Ji, Kai
2023-05-24 11:44 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1827753.atdPhlSkOF@thomas \
--to=thomas@monjalon.net \
--cc=Fangming.Fang@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=asekhar@marvell.com \
--cc=ciara.power@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=john.mcnamara@intel.com \
--cc=kai.ji@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).