From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Thomas Monjalon <thomas@monjalon.net>,
"Loftus, Ciara" <ciara.loftus@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"ferruh.yigit@xilinx.com" <ferruh.yigit@xilinx.com>
Subject: Re: [PATCH] net/af_xdp: limit libbpf version to <= v0.7.0
Date: Thu, 7 Jul 2022 14:19:19 +0300 [thread overview]
Message-ID: <183199df-9c7f-b4c1-fef2-355a46768223@oktetlabs.ru> (raw)
In-Reply-To: <34eee5ae-69a5-b39a-9187-8ab536fd5e88@oktetlabs.ru>
On 6/24/22 14:48, Andrew Rybchenko wrote:
> On 6/24/22 13:10, Thomas Monjalon wrote:
>> 24/06/2022 10:37, Loftus, Ciara:
>>>>
>>>> 24/06/2022 08:06, Ciara Loftus:
>>>>> Linking with libbpf v0.8.0 causes deprication warnings. As a temporary
>>>>> measure, prevent linking with libbpf versions v0.8.0 and greater. This
>>>>> limitation should be removed in the future when appropriate
>>>>> compatibility measures are introduced.
>>>>>
>>>>> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
>>>>> ---
>>>>> -bpf_dep = dependency('libbpf', required: false, method: 'pkg-config')
>>>>> -if not bpf_dep.found()
>>>>> - bpf_dep = cc.find_library('bpf', required: false)
>>>>> -endif
>>>>> +bpf_dep = dependency('libbpf', version : '<=0.7.0', required: false,
>>>> method: 'pkg-config')
>>>>
>>>> It is also removing the find_library() method.
>>>> Any reason it was there?
>>>>
>>>
>>> My understanding is that one can't check the library version using
>>> that method.
>>> So it was a valid method of picking up the library until now where we
>>> always need to check the version before linking.
>>
>> OK I see
>
> IMHO checking library version is a bad approach. We should file
> the library of whatever version and check for symbols etc in it
> and provide corresponding HAVE_ defines to handle it in code.
I'm marking the patch as discarded since it is a step in a wrong
direction.
prev parent reply other threads:[~2022-07-07 11:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 6:06 Ciara Loftus
2022-06-24 8:28 ` Thomas Monjalon
2022-06-24 8:37 ` Loftus, Ciara
2022-06-24 10:10 ` Thomas Monjalon
2022-06-24 11:48 ` Andrew Rybchenko
2022-07-07 11:19 ` Andrew Rybchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=183199df-9c7f-b4c1-fef2-355a46768223@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).