From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1 1/1] examples/quota_watermark: fix low_watermark variable placement
Date: Wed, 08 Jun 2016 22:36:21 +0200 [thread overview]
Message-ID: <183204323.ntq5UxT7Bb@xps13> (raw)
In-Reply-To: <1464005996-9463-1-git-send-email-piotrx.t.azarewicz@intel.com>
2016-05-23 14:19, Piotr Azarewicz:
> qw app at its init stage reserve 2*sizeof(int) memory space for quota
> and low_watermark shared variables, but both apps (qw and qwctl) assign
> wrong address for low_watermark pointer (out of reserved memzone space)
> due to wrong pointer arithmetic.
>
> CID 30709 : Extra sizeof expression (SIZEOF_MISMATCH)
> suspicious_pointer_arithmetic: Adding 4UL /* sizeof (int) */ to pointer
> (unsigned int *)(*qw_memzone).addr of type unsigned int * is suspicious
> because adding an integral value to this pointer automatically scales
> that value by the size, 4 bytes, of the pointed-to type, unsigned int.
> Most likely, sizeof (int) is extraneous and should be replaced with 1.
>
> Coverity issue: 30709
> Fixes: 1d6c3ee3321a ("examples/quota_watermark: initial import")
>
> Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
Applied, thanks
Is this example really useful?
prev parent reply other threads:[~2016-06-08 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 12:19 Piotr Azarewicz
2016-06-08 20:36 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=183204323.ntq5UxT7Bb@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=piotrx.t.azarewicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).