From: Thomas Monjalon <thomas@monjalon.net>
To: Tom Barbette <tom.barbette@ulg.ac.be>
Cc: dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] ethernet api: Document rte_eth_vmdq_rx_conf
Date: Sun, 09 Jul 2017 22:22:50 +0200 [thread overview]
Message-ID: <1841065.2mqPad39Ri@xps> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE23ED232A7@IRSMSX104.ger.corp.intel.com>
06/07/2017 10:29, Mcnamara, John:
> From: Tom Barbette [mailto:tom.barbette@ulg.ac.be]
> >
> > From documentation it is very unclear how VMDq configuration can be
> > tweaked, and online search offer very poor results.
> >
> > This patch will ultimately spawn an online documentation page for the
> > rte_eth_vmdq_rx_conf struct which will eventually add a bit of
> > documentation about the rx_mode tag and how to allow e.g. VMDq pools to
> > receive packets without VLAN tags.
> >
> > Signed-off-by: Tom Barbette <tom.barbette@ulg.ac.be>
>
> Hi Tom,
>
> Thanks for that. One minor, non-blocking, thing for future reference. The
> subject line should be lowercase apart from acronyms. The maintainer
> should be able to make that change when then apply the patch. This is just
> for future reference.
New title:
ethdev: document VMDq Rx configuration
> If there is any other missing documentation that you would care to add
> then please do. :-)
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied, thanks
prev parent reply other threads:[~2017-07-09 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 13:59 Tom Barbette
2017-07-06 8:29 ` Mcnamara, John
2017-07-09 20:22 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1841065.2mqPad39Ri@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=tom.barbette@ulg.ac.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).