From: Thomas Monjalon <thomas@monjalon.net>
To: "Singh, Aman Deep" <aman.deep.singh@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace
Date: Fri, 04 Feb 2022 08:47:51 +0100 [thread overview]
Message-ID: <1842607.g5d078U9FE@thomas> (raw)
In-Reply-To: <2f156089-44ad-776a-c483-9ff62c8c716a@intel.com>
04/02/2022 07:13, Singh, Aman Deep:
> Hi Thomas
>
> On 2/3/2022 2:31 AM, Thomas Monjalon wrote:
> > 23/01/2022 18:20, Aman Singh:
> >> Added two specific exceptions for ETH_SPEED_10G
> >> and ETH_SPEED_25G to avoid there name change.
> >> Added check for ETH_TUNNEL_FILTER and ETH_RSS_RETA
> > Please could you explain why?
> These two macro's ETH_SPEED_10G & ETH_SPEED_25G are used by ifpga
> driver and script should no change these.
> There are multiple ETH_SPEED_NUM_xxx macro that need to be changed
> to RTE_ETH_SPEED_NUM_xxx. So added above two as specific exceptions.
Why doing this exception? What is special with ifpga?
> The other two patterns ETH_TUNNEL_FILTER & ETH_RSS_RETA were missed before.
> The script should change these to RTE_ETH_TUNNEL_FILTER & RTE_ETH_RSS_RETA
The explanations should be part of the commit log please.
next prev parent reply other threads:[~2022-02-04 7:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 17:20 Aman Singh
2022-02-02 21:01 ` Thomas Monjalon
2022-02-04 6:13 ` Singh, Aman Deep
2022-02-04 7:47 ` Thomas Monjalon [this message]
2022-02-10 13:26 ` Singh, Aman Deep
2022-02-10 15:30 ` Thomas Monjalon
2022-02-11 8:07 ` Singh, Aman Deep
2022-02-11 17:28 ` Thomas Monjalon
2022-02-15 18:51 ` Singh, Aman Deep
2022-02-15 22:17 ` Thomas Monjalon
2022-02-17 6:34 ` Singh, Aman Deep
2022-03-07 14:27 ` [PATCH v3] " Aman Singh
2022-03-08 13:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1842607.g5d078U9FE@thomas \
--to=thomas@monjalon.net \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).