From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Remy Horton <remy.horton@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix multi-process NULL dereference crashes
Date: Wed, 25 Jan 2017 12:56:07 +0100 [thread overview]
Message-ID: <1844096.VBZFUxdXJL@xps13> (raw)
In-Reply-To: <1485270071-5407-1-git-send-email-remy.horton@intel.com>
2017-01-24 15:01, Remy Horton:
> Secondary processes were blanket zeroing ethernet device memory,
> resulting in NULL dereference crashes in multi-process setups.
>
> Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device")
>
> Signed-off-by: Remy Horton <remy.horton@intel.com>
> ---
> doc/guides/rel_notes/release_17_02.rst | 5 +++++
> lib/librte_ether/rte_ethdev.c | 4 +++-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/doc/guides/rel_notes/release_17_02.rst b/doc/guides/rel_notes/release_17_02.rst
> index 0ecd720..1472f84 100644
> --- a/doc/guides/rel_notes/release_17_02.rst
> +++ b/doc/guides/rel_notes/release_17_02.rst
> @@ -222,6 +222,11 @@ Drivers
> Fixed few regressions introduced in recent releases that break the virtio
> multiple process support.
>
> +* **ethdev: Fixed crash with multi-processing.**
> +
> + Secondary processes were blanket zeroing ethernet device memory,
> + resulting in NULL dereference crashes in multi-process setups.
It does not describe exactly the use-case it is fixing (same in commit message).
I guess you saw an issue when creating a vdev in the primary process and
another one in a secondary process, erasing the data of the first one.
nit: ethdev bug should be shown before PMD bugs like virtio one above.
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -225,8 +225,10 @@ rte_eth_dev_allocate(const char *name)
> return NULL;
> }
>
> - memset(&rte_eth_dev_data[port_id], 0, sizeof(struct rte_eth_dev_data));
> eth_dev = eth_dev_get(port_id);
> + if (rte_eal_process_type() == RTE_PROC_PRIMARY)
> + memset(&rte_eth_dev_data[port_id], 0,
> + sizeof(struct rte_eth_dev_data));
My previous proposal was:
memset(eth_dev->data, 0, sizeof(*eth_dev->data))
It is better to avoid reference to the global array rte_eth_dev_data.
Anyway, the shared data are still overwritten for the name, the port id
and the MTU.
Please describe the exact case where it is working for you.
next prev parent reply other threads:[~2017-01-25 11:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 18:42 [dpdk-dev] [PATCH v1] " Remy Horton
2017-01-11 14:22 ` Thomas Monjalon
2017-01-11 15:01 ` Remy Horton
2017-01-20 18:37 ` Thomas Monjalon
2017-01-24 8:16 ` Remy Horton
2017-01-24 10:49 ` Thomas Monjalon
2017-01-24 11:03 ` Remy Horton
2017-01-24 15:01 ` [dpdk-dev] [PATCH v2] " Remy Horton
2017-01-25 11:56 ` Thomas Monjalon [this message]
2017-01-25 12:13 ` Remy Horton
2017-01-25 14:02 ` Remy Horton
2017-01-25 14:31 ` Thomas Monjalon
2017-01-25 14:38 ` Remy Horton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1844096.VBZFUxdXJL@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).