DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH] devtools: check stable tag in fixes
Date: Tue, 17 Jan 2017 19:42:33 +0100	[thread overview]
Message-ID: <1860075.ojoIIAvjcn@xps13> (raw)
In-Reply-To: <d046362e-d41d-fcab-ec9b-23d651b84ebc@intel.com>

2017-01-17 18:15, Ferruh Yigit:
> On 1/17/2017 2:54 PM, Thomas Monjalon wrote:
> > The tag "Cc: stable@dpdk.org" must be set when the commit must be
> > backported to a stable branch.
> > 
> > It must be located just below the "Fixes:" tag (without blank line)
> > and followed by a blank line, separated from SoB and review tags below.
> 
> I am OK to keep it if it will help stable tree maintenance, but I still
> not clear about why we need this.
> 
> If a patch is a fix, it should already have "Fixes:" line, so this can
> be used to parse git history.

That's a question for Yuanhan. My comments below:

Some fixes are not candidate for the stable branch because the bug was
not in the previous release. These fixes are filtered out by the script
devtools/git-log-fixes.sh
Some fixes are not so important and we can decide they do not fit in
the stable branch. Who make this decision? Relying on this Cc tag would
mean the committers decide which patch to backport.

> If patch is a feature, as far as I know still can go to stable tree, but
> for this case stable tree maintainer decides this, and author putting
> "Cc: stable@dpdk.org" tag not so useful. Author can put this tag just
> for recommendation, but if so why we are saving this into git history?

No feature should be backported.

> Initially this was to be sure fixes CC'ed to stable mail list, now
> meaning is changing I guess. For the case author already cc'ed the
> stable tree but not put Cc: tag into git commit, should committer add
> this explicitly or ask from author a new version of the patch?

Yuanhan was suggesting that the committer can do it if an author forget.

> Last thing, if this tag will remain in the commit log, is this only for
> stable tree, or any "Cc: <mail_address>" can stay in the history?

I do not see the benefit of keeping other Cc in the history.
It is just a convenience for authors when using git-send-email.

  reply	other threads:[~2017-01-17 18:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17 14:54 Thomas Monjalon
2017-01-17 18:15 ` Ferruh Yigit
2017-01-17 18:42   ` Thomas Monjalon [this message]
2017-01-18  4:41     ` Yuanhan Liu
2017-01-18  8:32       ` Thomas Monjalon
2017-01-18  8:54         ` Yuanhan Liu
2017-01-18 17:25       ` Ferruh Yigit
2017-01-19  8:05         ` Yuanhan Liu
2017-01-19 12:00           ` Ferruh Yigit
2017-01-20  7:59             ` Yuanhan Liu
2017-01-20 10:10               ` Thomas Monjalon
2017-01-20 10:23                 ` Yuanhan Liu
2017-01-20 16:20                   ` Ferruh Yigit
2017-01-18  9:37 ` [dpdk-dev] [PATCH v2] devtools: relax tag checking " Thomas Monjalon
2017-01-18 10:04   ` Yuanhan Liu
2017-01-18 15:52     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1860075.ojoIIAvjcn@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).