From: Thomas Monjalon <thomas@monjalon.net>
To: Lukasz Majczak <lma@semihalf.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4] librte_eal: fix wrong assert for arm and ppc
Date: Fri, 06 Oct 2017 00:16:06 +0200 [thread overview]
Message-ID: <1861830.ytJZ7dK9I5@xps> (raw)
In-Reply-To: <20170928065459.6616-1-lma@semihalf.com>
28/09/2017 08:54, Lukasz Majczak:
> The assertion of return value from the open() function is done against
> 0, while it is a correct value - open() returns -1 in case of an error.
> It causes problems while trying to run as a daemon, in which case, this
> call to open() will return 0 as a valid descriptor.
>
> Fixes: b94e5c9406b5 ("eal/arm: add CPU flags for ARMv7")
> Fixes: 97523f822ba9 ("eal/arm: add CPU flags for ARMv8")
> Fixes: 9ae155385686 ("eal/ppc: cpu flag checks for IBM Power")
Cc: stable@dpdk.org
> Signed-off-by: Lukasz Majczak <lma@semihalf.com>
> Acked-by: Jan Viktorin <viktorin@rehivetech.com>
> Acked-by: Chao Zhu <chaozhu@linux.vnet.ibm.com>
Applied, thanks
prev parent reply other threads:[~2017-10-05 22:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170925073441.23494-1-lma@semihalf.com>
2017-09-28 6:54 ` [dpdk-stable] " Lukasz Majczak
2017-10-05 22:16 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1861830.ytJZ7dK9I5@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=lma@semihalf.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).