patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
Cc: dev@dpdk.org, stable@dpdk.org,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
	Xueming Li <xuemingl@nvidia.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Marcin Wojtas <mw@semihalf.com>,
	Michal Krawczyk <mk@semihalf.com>,
	Shai Brandes <shaibran@amazon.com>,
	Evgeny Schemeilin <evgenys@amazon.com>,
	Igor Chauskin <igorch@amazon.com>,
	Parav Pandit <parav@nvidia.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Long Li <longli@microsoft.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v5] bus: clarify log for non-NUMA-aware devices
Date: Wed, 04 Aug 2021 11:34:21 +0200	[thread overview]
Message-ID: <1862927.fmMXKf2Rp4@thomas> (raw)
In-Reply-To: <20210804080301.1440491-1-dkozlyuk@nvidia.com>

04/08/2021 10:03, Dmitry Kozlyuk:
> PCI, vmbus, and auxiliary drivers printed a warning
> when NUMA node had been reported as (-1) or not reported by OS:
> 
>     EAL:   Invalid NUMA socket, default to 0
> 
> This message and its level might confuse users because the configuration
> is valid and nothing happens that requires attention or intervention.
> It was also printed without the device identification and with an indent
> (PCI only), which is confusing unless DEBUG logging is on to print
> the header message with the device name.
> 
> Reduce level to INFO, reword the message, and suppress it when there is
> only one NUMA node because NUMA awareness does not matter in this case.
> Also, remove the indent for PCI.
> 
> Fixes: f0e0e86aa35d ("pci: move NUMA node check from scan to probe")
> Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support")
> Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Reviewed-by: Xueming Li <xuemingl@nvidia.com>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---
> The messages say "socket" and not "node", because this is current
> terminology in DPDK.

Yes we need to fix this terminology in a separate patch.

Applied, thanks.




      reply	other threads:[~2021-08-04  9:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 10:51 [dpdk-stable] [PATCH] " Dmitry Kozlyuk
2021-06-15 15:12 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2021-06-16 10:07 ` [dpdk-stable] [PATCH v2] " Dmitry Kozlyuk
2021-07-23 20:07   ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2021-07-27  8:08     ` Dmitry Kozlyuk
2021-07-27 10:27   ` [dpdk-stable] [PATCH v3] " Dmitry Kozlyuk
2021-07-28 22:06     ` [dpdk-stable] [PATCH v4] " Dmitry Kozlyuk
2021-07-29  7:45       ` Andrew Rybchenko
2021-07-30 16:18       ` Thomas Monjalon
2021-08-04  8:03       ` [dpdk-stable] [PATCH v5] " Dmitry Kozlyuk
2021-08-04  9:34         ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1862927.fmMXKf2Rp4@thomas \
    --to=thomas@monjalon.net \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=dkozlyuk@nvidia.com \
    --cc=evgenys@amazon.com \
    --cc=igorch@amazon.com \
    --cc=longli@microsoft.com \
    --cc=mk@semihalf.com \
    --cc=mw@semihalf.com \
    --cc=parav@nvidia.com \
    --cc=shaibran@amazon.com \
    --cc=stable@dpdk.org \
    --cc=sthemmin@microsoft.com \
    --cc=viacheslavo@nvidia.com \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).