From: Thomas Monjalon <thomas@monjalon.net>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: stable@dpdk.org, Jan Blunck <jblunck@infradead.org>,
dev@dpdk.org, Ilya Matveychikov <matvejchikov@gmail.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
sergio.gonzalez.monroy@intel.com,
santosh.shukla@caviumnetworks.com
Subject: Re: [dpdk-stable] [PATCH v2] eal: don't advertise a physical address when no hugepages
Date: Tue, 04 Jul 2017 17:53:54 +0200 [thread overview]
Message-ID: <1867099.27613Eycdk@xps> (raw)
In-Reply-To: <CALe+Z03uCcDCcvXjA2zykTozE_vcAPgMk5TEKeRU=F=zi1Bq7A@mail.gmail.com>
03/07/2017 12:17, Jan Blunck:
> On Mon, Jul 3, 2017 at 12:04 PM, Olivier Matz <olivier.matz@6wind.com> wrote:
> > When populating a mempool with a virtual memory area, the mempool
> > library expects to be able to get the physical address of each page.
> >
> > When started with --no-huge, the physical addresses may not be available
> > because the pages are not locked in memory. It sometimes returns
> > RTE_BAD_PHYS_ADDR, which makes the mempool_populate() function to fail.
> >
> > This was working before the commit cdc242f260e7 ("eal/linux: support
> > running as unprivileged user"), because rte_mem_virt2phy() was returning
> > 0 instead of RTE_BAD_PHYS_ADDR, which was seen as a valid physical
> > address.
> >
> > Since --no-huge is a debug function that breaks the support of physical
> > drivers, always set physical addresses to RTE_BAD_PHYS_ADDR in memzones
> > or in rte_mem_virt2phy(), and ensure that mempool won't complain in that
> > case.
> >
> > Fixes: cdc242f260e7 ("eal/linux: support running as unprivileged user")
> >
> > CC: stable@dpdk.org
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
> Reviewed-by: Jan Blunck <jblunck@infradead.org>
Applied, thanks
prev parent reply other threads:[~2017-07-04 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170609102727.0eb7f39d@platinum>
2017-06-09 8:29 ` [dpdk-stable] [PATCH] " Olivier Matz
2017-06-10 8:31 ` Jan Blunck
2017-06-23 8:11 ` Olivier Matz
2017-06-23 17:08 ` Jan Blunck
2017-06-26 7:11 ` [dpdk-stable] [dpdk-dev] " santosh
2017-06-12 13:58 ` [dpdk-stable] " Adrien Mazarguil
2017-07-03 10:04 ` [dpdk-stable] [PATCH v2] " Olivier Matz
2017-07-03 10:17 ` Jan Blunck
2017-07-04 15:53 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1867099.27613Eycdk@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=jblunck@infradead.org \
--cc=matvejchikov@gmail.com \
--cc=olivier.matz@6wind.com \
--cc=santosh.shukla@caviumnetworks.com \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).