DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Cc: dev@dpdk.org, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com
Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix build error for gcc 4.8
Date: Tue, 14 Jun 2016 21:04:16 +0200	[thread overview]
Message-ID: <1868672.fp3FqAkN9z@xps13> (raw)
In-Reply-To: <1465472328-226671-1-git-send-email-danielx.t.mrzyglod@intel.com>

2016-06-09 13:38, Daniel Mrzyglod:
> This patch fixes a maybe-uninitialized warning when compiling DPDK with GCC 4.8
> 
> examples/ip_pipeline/pipeline/pipeline_common_fe.c: In function 'app_pipeline_track_pktq_out_to_link':
> examples/ip_pipeline/pipeline/pipeline_common_fe.c:66:31: error:
> 'reader' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
>    struct app_pktq_out_params *pktq_out =
> 
> Fixes: 760064838ec0 ("examples/ip_pipeline: link routing output ports to devices")
> 
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>

For a weird reason, this patch triggers a new error:

examples/ip_pipeline/pipeline/pipeline_common_fe.c:In function ‘app_pipeline_track_pktq_out_to_link’:
examples/ip_pipeline/pipeline/pipeline_common_fe.c:124:11:
error: ‘id’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
    status = ptype->fe_ops->f_track(&pp,
           ^
In file included from examples/ip_pipeline/pipeline/pipeline_common_fe.h:44:0,
                 from examples/ip_pipeline/pipeline/pipeline_common_fe.c:47:
examples/ip_pipeline/app.h:734:26: note: ‘id’ was declared here
  uint32_t n_readers = 0, id, i;
                          ^
examples/ip_pipeline/pipeline/pipeline_common_fe.c:97:11:
error: ‘id’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
    status = ptype->fe_ops->f_track(&pp,
           ^
In file included from examples/ip_pipeline/pipeline/pipeline_common_fe.h:44:0,
                 from examples/ip_pipeline/pipeline/pipeline_common_fe.c:47:
examples/ip_pipeline/app.h:674:26: note: ‘id’ was declared here
  uint32_t n_readers = 0, id, i;
                          ^

  parent reply	other threads:[~2016-06-14 19:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09 11:38 Daniel Mrzyglod
2016-06-09 10:52 ` Dumitrescu, Cristian
2016-06-14 19:04 ` Thomas Monjalon [this message]
2016-06-16 13:35   ` Jastrzebski, MichalX K
2016-06-21  9:35 ` [dpdk-dev] [PATCH v2] " Daniel Mrzyglod
2016-06-21 17:43   ` Dumitrescu, Cristian
2016-06-22  8:44     ` Mrzyglod, DanielX T
2016-06-22  8:45   ` Mrzyglod, DanielX T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1868672.fp3FqAkN9z@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=danielx.t.mrzyglod@intel.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).