From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Simon Kagstrom <simon.kagstrom@netinsight.net>
Cc: dev@dpdk.org, reshma.pattan@intel.com
Subject: Re: [dpdk-dev] [PATCH / RFC ] ethdev: Allow rte_eth_dev_configure with zero RX/TX queues
Date: Thu, 23 Jun 2016 17:53:34 +0200 [thread overview]
Message-ID: <1881092.YNl14ETpPN@xps13> (raw)
In-Reply-To: <20160516113349.7d2a992f@miho>
2016-05-16 11:33, Simon Kagstrom:
> This allows releasing RX/TX queue memory.
> ---
> We're using DPDK 16.04 and have a test suite which performs a sequence
> of separate tests of the type
>
> allocate mempool
> rte_eth_dev_configure(port, n_rxq, n_txq, ...)
> setup rx/tx queues
> rte_eth_dev_start(port)
>
> <perform actual test>
>
> stop rx/tx queues
> rte_eth_dev_stop(port)
>
> -> rte_eth_dev_configure(port, 0, 0, ...)
>
> check that there are no leaks from the mempool
>
> The crucial point is the marked line above. This is done so that the
> rx_queue_release/tx_queue_release callbacks in the PMD is called, so
> that mbufs allocated by the driver is released.
I think you are trying to use a side effect of rte_eth_dev_configure().
After calling rte_eth_dev_stop(), I would say the clean-up should be done
by rte_eth_dev_close().
Why not using close?
next prev parent reply other threads:[~2016-06-23 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 9:33 Simon Kagstrom
2016-05-16 10:24 ` Pattan, Reshma
2016-05-16 10:32 ` Simon Kågström
2016-05-16 12:43 ` Pattan, Reshma
2016-05-16 13:16 ` Simon Kågström
2016-05-20 6:29 ` Simon Kågström
2016-05-20 8:26 ` Pattan, Reshma
2016-06-23 15:53 ` Thomas Monjalon [this message]
2018-12-20 23:34 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1881092.YNl14ETpPN@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=simon.kagstrom@netinsight.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).