From: Thomas Monjalon <thomas@monjalon.net>
To: cristian.dumitrescu@intel.com
Cc: stable@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>,
dev@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix bitmap documentation
Date: Wed, 01 Aug 2018 17:55:31 +0200 [thread overview]
Message-ID: <1885451.eFXLNhJiRH@xps> (raw)
In-Reply-To: <20180717171417.31425-1-jerin.jacob@caviumnetworks.com>
Cristian, review please?
17/07/2018 19:14, Jerin Jacob:
> n_bits comes as first argument, align doxygen comment.
>
> n_bit need to not be multiple of 512 as n_bits
> are rounding to RTE_BITMAP_CL_BIT_SIZE.
>
> Fixes: 14456f59e9f7 ("doc: fix doxygen warnings in QoS API")
> Fixes: de3cfa2c9823 ("sched: initial import")
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> lib/librte_eal/common/include/rte_bitmap.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/librte_eal/common/include/rte_bitmap.h b/lib/librte_eal/common/include/rte_bitmap.h
> index 7d4935fcc..d9facc642 100644
> --- a/lib/librte_eal/common/include/rte_bitmap.h
> +++ b/lib/librte_eal/common/include/rte_bitmap.h
> @@ -198,12 +198,12 @@ rte_bitmap_get_memory_footprint(uint32_t n_bits) {
> /**
> * Bitmap initialization
> *
> - * @param mem_size
> - * Minimum expected size of bitmap.
> + * @param n_bits
> + * Number of pre-allocated bits in array2.
> * @param mem
> * Base address of array1 and array2.
> - * @param n_bits
> - * Number of pre-allocated bits in array2. Must be non-zero and multiple of 512.
> + * @param mem_size
> + * Minimum expected size of bitmap.
> * @return
> * Handle to bitmap instance.
> */
>
next prev parent reply other threads:[~2018-08-01 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 17:14 Jerin Jacob
2018-08-01 15:55 ` Thomas Monjalon [this message]
2018-08-02 14:34 ` Dumitrescu, Cristian
2018-08-05 18:12 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1885451.eFXLNhJiRH@xps \
--to=thomas@monjalon.net \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).