From: "Pei, Yulong" <yulong.pei@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add bus info when display port info
Date: Tue, 2 May 2017 01:58:58 +0000 [thread overview]
Message-ID: <188971FCDA171749BED5DA74ABF3E6F03B6C56DC@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <2267864.xljogAfNJv@xps>
Hi Thomas,
-----Original Message-----
From: Thomas Monjalon [mailto:thomas@monjalon.net]
Sent: Monday, May 1, 2017 9:56 PM
To: Pei, Yulong <yulong.pei@intel.com>
Cc: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add bus info when display port info
26/04/2017 06:31, Yulong Pei:
> Display pci device bus info when show port info.
>
> Signed-off-by: Yulong Pei <yulong.pei@intel.com>
> ---
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -469,6 +469,14 @@ port_infos_display(portid_t port_id)
> print_ethaddr("MAC address: ", &mac_addr);
> printf("\nDriver name: %s", dev_info.driver_name);
> printf("\nConnect to socket: %u", port->socket_id);
> + if (dev_info.pci_dev)
> + printf("\nBus-info: %04x:%02x:%02x:%x",
> + dev_info.pci_dev->addr.domain,
> + dev_info.pci_dev->addr.bus,
> + dev_info.pci_dev->addr.devid,
> + dev_info.pci_dev->addr.function);
> + else
> + printf("\nBus-info: N/A");
The bus information must be managed in a more generic way.
The field pci_dev will probably be removed in a next release.
Could you kind to tell me more information about what does "more generic way" mean ?
Best Regards
Yulong Pei
next prev parent reply other threads:[~2017-05-02 1:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 4:31 Yulong Pei
2017-04-28 7:46 ` Wu, Jingjing
2017-05-01 13:56 ` Thomas Monjalon
2017-05-02 1:58 ` Pei, Yulong [this message]
2017-05-02 9:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=188971FCDA171749BED5DA74ABF3E6F03B6C56DC@shsmsx102.ccr.corp.intel.com \
--to=yulong.pei@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).