DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: dev@dpdk.org, "Shaw, Jeffrey B" <jeffrey.b.shaw@intel.com>,
	"Zhang, Helin" <helin.zhang@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] i40e: Add packet_type metadata in the i40e	vPMD
Date: Fri, 23 Sep 2016 10:23:16 +0200	[thread overview]
Message-ID: <1890771.aBr4rjc9Og@xps13> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E706115064D652@SHSMSX103.ccr.corp.intel.com>

2016-09-23 06:40, Zhang, Qi Z:
> > From: Damjan Marion <damarion@cisco.com>
> > 
> > The ptype is decoded from the rx descriptor and stored in the packet type field
> > in the mbuf using the same function as the non-vector driver.
> > 
> > Signed-off-by: Damjan Marion <damarion@cisco.com>
> > Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> 
> Acted-by: Zhang Qi <qi.z.zhang@intel.com>

It should be Acked-by :)

Just a note about name convention:
In DPDK we use the english naming style which is to put the first name
first and the surname last.
I believe your surname is Zhang so maybe you should write:
	Acked-by: Qi Zhang <qi.z.zhang@intel.com>

By the way, thanks for reviewing.

  reply	other threads:[~2016-09-23  8:23 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14 16:59 [dpdk-dev] [PATCH 0/2] Add ptype and xsum handling in i40e rx vpmd Jeff Shaw
2016-07-14 16:59 ` [dpdk-dev] [PATCH 1/2] i40e: Add packet_type metadata in the i40e vPMD Jeff Shaw
2016-09-23  6:40   ` Zhang, Qi Z
2016-09-23  8:23     ` Thomas Monjalon [this message]
2016-09-26  1:46       ` Zhang, Qi Z
2016-10-05  1:29   ` Chen, Jing D
2016-10-06  0:12   ` [dpdk-dev] [PATCH v2 " Jeff Shaw
2016-10-05 21:26     ` Chen, Jing D
2016-10-06  0:12     ` [dpdk-dev] [PATCH v2 2/2] i40e: Enable bad checksum flags in " Jeff Shaw
2016-10-05 22:20       ` Chen, Jing D
2016-10-05 23:57       ` Chen, Jing D
2016-10-06  2:19         ` Jeff Shaw
2016-10-06  7:54           ` Damjan Marion (damarion)
2016-10-06  6:33       ` [dpdk-dev] [PATCH v3 1/2] i40e: Add packet_type metadata in the " Jeff Shaw
2016-10-06  6:38       ` [dpdk-dev] [PATCH v4 " Jeff Shaw
2016-10-06  6:38         ` [dpdk-dev] [PATCH v4 2/2] i40e: Enable bad checksum flags in " Jeff Shaw
2016-10-06 15:30           ` Chen, Jing D
2016-10-06 15:28         ` [dpdk-dev] [PATCH v4 1/2] i40e: Add packet_type metadata in the " Chen, Jing D
2016-10-12 15:51           ` Bruce Richardson
2016-07-14 16:59 ` [dpdk-dev] [PATCH 2/2] i40e: Enable bad checksum flags in " Jeff Shaw
2016-07-15 20:26 ` [dpdk-dev] [PATCH 0/2] Add ptype and xsum handling in i40e rx vpmd Thomas Monjalon
2016-09-01 14:47   ` Jeff Shaw
2016-09-14 13:22     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1890771.aBr4rjc9Og@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=jeffrey.b.shaw@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).