From: Thomas Monjalon <thomas@monjalon.net>
To: Aman Kumar <aman.kumar@vvdntech.in>,
David Marchand <david.marchand@redhat.com>,
"Song, Keesang" <keesang.song@amd.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform
Date: Tue, 02 Nov 2021 20:04:54 +0100 [thread overview]
Message-ID: <1902057.C4l9sbjloW@thomas> (raw)
In-Reply-To: <CAJFAV8z5vVuCALNcQG9PnTkGViyocfKNxXcR4tCYVTdbo+enSA@mail.gmail.com>
02/11/2021 19:45, David Marchand:
> On Tue, Nov 2, 2021 at 3:53 PM Aman Kumar <aman.kumar@vvdntech.in> wrote:
> >
> > -Dcpu_instruction_set=znverX meson option can be used
> > to build dpdk for AMD platforms. Supported options are
> > znver1, znver2 and znver3.
> >
> > Signed-off-by: Aman Kumar <aman.kumar@vvdntech.in>
> > ---
> > config/x86/meson.build | 9 +++++++++
> > doc/guides/linux_gsg/build_dpdk.rst | 2 +-
> > 2 files changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/config/x86/meson.build b/config/x86/meson.build
> > index 29f3dea181..21cda6fd33 100644
> > --- a/config/x86/meson.build
> > +++ b/config/x86/meson.build
> > @@ -72,3 +72,12 @@ endif
> > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)
> > dpdk_conf.set('RTE_MAX_LCORE', 128)
> > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
> > +
> > +# AMD platform support
> > +if get_option('cpu_instruction_set') == 'znver1'
> > + dpdk_conf.set('RTE_MAX_LCORE', 256)
> > +elif get_option('cpu_instruction_set') == 'znver2'
> > + dpdk_conf.set('RTE_MAX_LCORE', 512)
> > +elif get_option('cpu_instruction_set') == 'znver3'
> > + dpdk_conf.set('RTE_MAX_LCORE', 512)
> > +endif
>
> I already replied to a similar patch earlier in this release.
> https://inbox.dpdk.org/dev/CAJFAV8z-5amvEnr3mazkTqH-7SZX_C6EqCua6UdMXXHgrcmT6g@mail.gmail.com/
>
> So repeating the same: do you actually _need_ more than 128 lcores in
> a single DPDK application?
Yes I forgot this previous discussion concluding that we should not increase
more than 128 threads.
The --lcores syntax and David's work on rte_thread_register should unblock
most of use cases.
next prev parent reply other threads:[~2021-11-02 19:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 14:52 Aman Kumar
2021-11-02 15:18 ` Thomas Monjalon
2021-11-02 15:56 ` Song, Keesang
2021-11-02 18:45 ` David Marchand
2021-11-02 19:04 ` Thomas Monjalon [this message]
2021-11-18 12:25 ` Thomas Monjalon
2021-11-18 13:52 ` Bruce Richardson
2021-11-18 14:05 ` Thomas Monjalon
2021-11-24 12:36 ` Thomas Monjalon
2021-12-17 20:12 ` Song, Keesang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1902057.C4l9sbjloW@thomas \
--to=thomas@monjalon.net \
--cc=aman.kumar@vvdntech.in \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=keesang.song@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).