From: Thomas Monjalon <thomas@monjalon.net>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix namespace of sysfs path function
Date: Tue, 07 Nov 2017 00:44:34 +0100 [thread overview]
Message-ID: <1908722.EftEn6FQRr@xps> (raw)
In-Reply-To: <20171106084334.GN10890@bidouze.vm.6wind.com>
06/11/2017 09:43, Gaëtan Rivet:
> There are others namespace inconsistencies with my pci move, I will send
> additional fixes later.
>
> On Mon, Nov 06, 2017 at 03:08:47AM +0100, Thomas Monjalon wrote:
> > The function pci_get_sysfs_path was moved from EAL to the PCI driver.
> >
> > The namespace is now fixed by adding "rte_" prefix.
> > The map files are fixed by removing the symbol from EAL and adding
> > it to the PCI driver.
> >
> > It is an API break but it is probably not used by applications.
> > Anyway this API is already broken by the move in a new header file.
> >
> > Fixes: c752998b5e2e ("pci: introduce library and driver")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied
prev parent reply other threads:[~2017-11-06 23:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 2:08 Thomas Monjalon
2017-11-06 8:43 ` Gaëtan Rivet
2017-11-06 23:44 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1908722.EftEn6FQRr@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).