From: Thomas Monjalon <thomas@monjalon.net>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org, adrien.mazarguil@6wind.com
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add flow API rule copy function
Date: Wed, 28 Jun 2017 00:00:02 +0200 [thread overview]
Message-ID: <1925976.ZpGJHZ6fsM@xps> (raw)
In-Reply-To: <c3dbfe0bda1da236f10023f379329e985281b9c2.1495207150.git.gaetan.rivet@6wind.com>
19/05/2017 17:21, Gaetan Rivet:
> +/**
> + * Flow elements description tables.
> + */
> +struct rte_flow_desc_data {
> + const char *name;
> + size_t size;
> +};
> +
> +extern const struct rte_flow_desc_data rte_flow_desc_item[];
> +extern size_t rte_flow_nb_item;
> +
> +extern const struct rte_flow_desc_data rte_flow_desc_action[];
> +extern size_t rte_flow_nb_action;
Those externs are weirds.
At least, it needs to be declared in the .map:
--- a/lib/librte_ether/rte_ether_version.map
+++ b/lib/librte_ether/rte_ether_version.map
@@ -153,6 +153,10 @@ DPDK_17.08 {
global:
rte_flow_copy;
+ rte_flow_desc_action;
+ rte_flow_desc_item;
rte_flow_isolate;
+ rte_flow_nb_action;
+ rte_flow_nb_item;
} DPDK_17.05;
next prev parent reply other threads:[~2017-06-27 22:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 15:09 [dpdk-dev] [PATCH] " Gaetan Rivet
2017-05-19 15:21 ` [dpdk-dev] [PATCH v2] " Gaetan Rivet
2017-06-27 21:48 ` Thomas Monjalon
2017-06-27 22:00 ` Thomas Monjalon [this message]
2017-07-06 16:56 ` [dpdk-dev] [PATCH v3] " Adrien Mazarguil
2017-07-06 17:11 ` Gaëtan Rivet
2017-07-07 0:08 ` [dpdk-dev] [PATCH v4] " Gaetan Rivet
2017-07-08 15:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1925976.ZpGJHZ6fsM@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).