DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib: remove "extern" keyword for functions from header files
Date: Thu, 28 Jan 2016 14:39:39 +0100	[thread overview]
Message-ID: <1940526.tdz5MxOLn2@xps13> (raw)
In-Reply-To: <20160128101113.GA9647@sivlogin002.ir.intel.com>

2016-01-28 10:11, Ferruh Yigit:
> On Wed, Jan 27, 2016 at 07:05:52PM +0100, Thomas Monjalon wrote:
> > 2016-01-25 10:01, Ferruh Yigit:
> > > Remove "extern" keywords in header files, the ones for function
> > > prototypes
> > 
> > I've seen a lot of other extern keywords. Why not removing all?
> > 
> Remaining one are Linux drivers in KNI, they are kind of internal headers, I doubt on touching them.
> Should I remove them all?
> Also there are more usage in "drivers" folder, I am not sure touching them too, what do you comment?
> 
> > > -extern int rte_eth_dev_configure(uint8_t port_id,
> > > -				 uint16_t nb_rx_queue,
> > > -				 uint16_t nb_tx_queue,
> > > -				 const struct rte_eth_conf *eth_conf);
> > > +int rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_queue,
> > > +			  uint16_t nb_tx_queue,
> > > +			  const struct rte_eth_conf *eth_conf);
> > 
> > The indent is weird.
> > Why not follow the guideline with 2 tabs?
> > http://dpdk.org/doc/guides-2.2/contributing/coding_style.html#c-indentation
> 
> Intentionally kept them as original, to scope the patch just to remove a keyword.
> Do you want me fix the syntax wherever I touch for this patch?

Syntax? Do you mean to fix the indent?
Yes I think it is a good practice to fix the indent when modifying some code.

  reply	other threads:[~2016-01-28 13:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 10:01 Ferruh Yigit
2016-01-27 18:05 ` Thomas Monjalon
2016-01-28 10:11   ` Ferruh Yigit
2016-01-28 13:39     ` Thomas Monjalon [this message]
2016-01-28 14:31       ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2016-01-28 17:04         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1940526.tdz5MxOLn2@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).