DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: bruce.richardson@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] Add toeplitz hash algorithm used by RSS
Date: Tue, 16 Jun 2015 11:07:28 +0200	[thread overview]
Message-ID: <1943830.H0qqKjE30e@xps13> (raw)
In-Reply-To: <2783732.C59rBDiv7h@xps13>

2015-06-03 16:07, Thomas Monjalon:
> 2015-05-08 10:58, Vladimir Medvedkin:
> > Software implementation of the Toeplitz hash function used by RSS.
> > Can be used either for packet distribution on single queue NIC
> > or for simulating of RSS computation on specific NIC (for example
> > after GRE header decapsulating).
> > 
> > v3 changes
> > - Rework API to be more generic
> > - Add sctp_tag into tuple
> > 
> > v2 changes
> > - Add ipv6 support
> > - Various style fixes
> > 
> > Signed-off-by: Vladimir Medvedkin <medvedkinv@gmail.com>
> > ---
> >  lib/librte_hash/Makefile    |   1 +
> >  lib/librte_hash/rte_thash.h | 207 ++++++++++++++++++++++++++++++++++++++++++++
> 
> Without any comment, it seems this v3 is approved.
> Maybe that this patch would be even better by implementing some unit tests.
> I wonder if the hash chapter of the prog guide could list the different
> algorithms and why/when use them?

Bruce, any opinion?
Don't you think that unit tests are required?

  reply	other threads:[~2015-06-16  9:08 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 19:06 [dpdk-dev] [PATCH] Add toeplitz hash algorithm Vladimir Medvedkin
2015-04-08 22:24 ` Stephen Hemminger
2015-04-09 12:50   ` Vladimir Medvedkin
2015-04-09  6:37 ` Gleb Natapov
2015-04-09 12:57   ` Vladimir Medvedkin
2015-05-05 13:20 ` [dpdk-dev] [PATCH v2] Add toeplitz hash algorithm used by RSS Vladimir Medvedkin
2015-05-05 16:03   ` Chilikin, Andrey
2015-05-07 10:28     ` Vladimir Medvedkin
2015-05-07 11:38       ` Chilikin, Andrey
2015-05-08 14:58         ` Vladimir Medvedkin
2015-05-08 14:58   ` Vladimir Medvedkin
2015-06-03 14:07     ` Thomas Monjalon
2015-06-16  9:07       ` Thomas Monjalon [this message]
2015-06-16 10:36         ` Bruce Richardson
2015-06-16 12:29     ` Bruce Richardson
2015-06-16 19:26       ` Vladimir Medvedkin
2015-06-19 14:55     ` [dpdk-dev] [PATCH v4] " Vladimir Medvedkin
2015-06-19 15:59       ` Richardson, Bruce
2015-06-19 16:14         ` Vladimir Medvedkin
2015-06-29 12:18           ` Bruce Richardson
2015-06-19 16:33         ` Mcnamara, John
2015-06-19 17:31       ` [dpdk-dev] [PATCH v5] " Vladimir Medvedkin
2015-06-29 12:40         ` Bruce Richardson
2015-06-30 12:14           ` Vladimir Medvedkin
2015-06-30 12:48             ` Bruce Richardson
2015-06-30 23:40         ` [dpdk-dev] [PATCH v6] " Vladimir Medvedkin
2015-07-01 15:29           ` Bruce Richardson
2015-07-01 21:23             ` Thomas Monjalon
2015-07-22  7:55           ` Tony Lu
2015-07-27 11:57             ` Vladimir Medvedkin
2015-07-29  5:01               ` Qiu, Michael
2015-07-29 14:00                 ` Vladimir Medvedkin
2015-06-19 17:32       ` [dpdk-dev] [PATCH v3] Add unit test for thash library Vladimir Medvedkin
2015-06-29 12:42         ` Bruce Richardson
2015-06-30 23:41         ` [dpdk-dev] [PATCH v4] " Vladimir Medvedkin
2015-07-01 15:30           ` Bruce Richardson
2015-07-01 21:28             ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1943830.H0qqKjE30e@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).